Skip to content

Player/MarioPhysics: fix keepDistance edge cases - #237

Merged
Mrkol merged 1 commit into
doldecomp:mainfrom
gitRasheed:pr/Player-MarioPhysics
Oct 1, 2026
Merged

Mrkol merged 1 commit into
doldecomp:mainfrom
gitRasheed:pr/Player-MarioPhysics

Conversation

@gitRasheed

Copy link
Copy Markdown
Contributor

keepDistance sets dx along with dist in the zero-distance fallback and skips the move when the step is not positive.

@decomp-dev

decomp-dev Bot commented Sep 30, 2026

Copy link
Copy Markdown

Report for GMSP01 (2749193 - b1641d4)

📈 1 improvement in an unmatched item
Unit Item Bytes Before After
mario/Player/MarioPhysics TMario::keepDistance(const JGeometry::TVec3<float>&, float, float) +13 93.82% 95.15%

Report for GMSJ01 (2749193 - b1641d4)

📈 1 improvement in an unmatched item
Unit Item Bytes Before After
mario/Player/MarioPhysics TMario::keepDistance(const JGeometry::TVec3<float>&, float, float) +13 93.82% 95.15%

@Mrkol
Mrkol merged commit 13f5a84 into doldecomp:main Oct 1, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants