Fix slant problem - #157
Open
SavchenkoValeriy wants to merge 1 commit into
Open
Conversation
Author
|
@domtronn ping |
Collaborator
|
How did you generate this new font file? |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, first of all thanks for you great work, your packages really improved the look of Emacs!
Back to business! Many people have encountered a very annoying slant bug in your package spaceline-all-the-icons: (issues #99, #90, #64, and #51). I think I've figured it out at least one part of the problem: slant symbol was not reaching the baseline:
It still requires tinkering with
spaceline-all-the-icons-separator-scale, but at least now it's possible for me (on my mac and linux pc) to find values that it looks perfect.