Repository navigation
Conversation
There was a problem hiding this comment.
🔵 Needs a closer look
The jQuery Validation license must be retained alongside the third-party JavaScript files that remain in the sample.
No open issues 🎉
What changed in this PR
This PR supports the repository cleanup in #37810 by deleting 21 files classified as orphaned includes from the ASP.NET Core documentation tree.
Changes:
- Removes unused tutorial, security, SignalR, and release-note includes.
- Deletes shared notices, diagram sources, and older guidance fragments.
- Deletes a bundled jQuery Validation license from the Razor Pages sample assets.
| File | Description |
|---|---|
aspnetcore/tutorials/first-mvc-app/details/includes/details9.md |
Removes the .NET 9 MVC details include. |
aspnetcore/signalr/redis-backplane/includes/redis-backplane.md |
Removes older Redis backplane guidance. |
aspnetcore/security/includes/choose-identity-diagram.md |
Removes identity-selection diagram source. |
aspnetcore/security/authentication/social/includes/default-settings2-2.md |
Removes older authentication-scheme guidance. |
aspnetcore/security/authentication/includes/mike-auth-powertags.md |
Removes an authentication placeholder. |
aspnetcore/release-notes/aspnetcore-9/includes/websockets-keep-alive-timeout.md |
Removes the WebSocket timeout release-note include. |
aspnetcore/release-notes/aspnetcore-9/includes/openAPI_completion.md |
Removes OpenAPI feature release-note content. |
aspnetcore/release-notes/aspnetcore-9/includes/newFeature1.md |
Removes a release-note authoring placeholder. |
aspnetcore/release-notes/aspnetcore-11/includes/direct-tls-transport.md |
Removes the experimental DirectTls include. |
aspnetcore/release-notes/aspnetcore-10/includes/OpenApiNetV2Prev7.md |
Removes an OpenAPI.NET preview upgrade include. |
aspnetcore/migration/fx-to-core/inc/includes/mermaid.md |
Removes migration diagram sources. |
aspnetcore/includes/RP/code/wwwroot/lib/jquery-validation/LICENSE.md |
Deletes the vendored library’s license notice. |
aspnetcore/includes/preview-notice.md |
Removes a prerelease notice. |
aspnetcore/includes/not-ga-yet.md |
Removes a prerelease notice and authoring instructions. |
aspnetcore/includes/monikerSdks/moniker8-9-10-sdk.md |
Removes version-specific SDK includes. |
aspnetcore/includes/mac-terminal-access.md |
Removes older Mac terminal instructions. |
aspnetcore/includes/combine-service-collection-60-or-later.md |
Removes service-registration guidance. |
aspnetcore/includes/combine-service-collection-31-to-60.md |
Removes an empty include. |
aspnetcore/fundamentals/minimal-apis/handle-errors/includes/handle-errors7.md |
Removes .NET 7 Minimal API error-handling guidance. |
aspnetcore/client-side/spa/intro/mermaid/includes/2BP.md |
Removes the SPA request-proxy diagram source. |
aspnetcore/client-side/spa/intro/mermaid/includes/1_BPS.md |
Removes the SPA proxy-startup diagram source. |
Review effort: Balanced
|
@guardrex Can you review when you get a chance? |
This comment was marked as resolved.
This comment was marked as resolved.
|
Regarding Experimental DirectTls transport ... Wade removed it ( @SamMonoRT @danroth27, do you know if that isn't going to make the cut for 11? If not for 11, would it make 12? If for 12, I'll save the content for it and place it for 12 separately later. |
guardrex
left a comment
guardrex
left a comment
There was a problem hiding this comment.
Let's hold for a sec for guidance on that one .NET 11 (or 12) feature.
WRT not-ga-yet.md and/or preview-notice.md, those were occasionally used in the past. We were placing a notice at the tops of new articles for new features. AFAIK, that's still a valid approach for new articles covering new features. I'm not sure why there are two of them. It looks like the one with the HTML comment is the better of the two, so perhaps that one should remain. However, I think the title "preview notice" is better as a file name for it (preview-notice.md).
|
@Youssef1313 ... There's a .NET 9-era INCLUDES file aspnetcore/release-notes/aspnetcore-9/includes/openAPI_completion.md that was pulled from the 9.0 release notes that pertains to ...
|
|
@BrennanConroy ... There's a Keep-Alive Timeout for WebSockets INCLUDES file ... ... which was added recently on #37499 to make up for the fact that it was missed. Therefore, I'm not sure why the INCLUDES file isn't part of the 9.0 release notes. Kind'a looks like it was placed and then pulled at some later date but never made its way back into the file when it finally was released with 9.0. Should I place the link to the INCLUDES file in the 9.0 release notes (and @gewarren can remove the deletion of it from this PR)? |
|
Looks like a mistake, let's add it (back?) to the release notes. |
|
@BrennanConroy ... Very well. 👍 @gewarren ... I'll take care of adding it back. Please retain |
Contributes to #37810