Skip to content

Fix auto-triage comment preparation and quota misuse - #4693

Open
priyankatiwari08 wants to merge 1 commit into
dotnet:mainfrom
priyankatiwari08:dev/automation/auto-triage-incomplete-result
Open

priyankatiwari08 wants to merge 1 commit into
dotnet:mainfrom
priyankatiwari08:dev/automation/auto-triage-incomplete-result

Conversation

@priyankatiwari08

Copy link
Copy Markdown
Contributor

Description

Fix the failure in https://github.com/dotnet/SqlClient/actions/runs/34991102115: generated instructions recommended jq, but the workflow denied it. During debugging the agent posted test comment, exhausting add_comment's one-comment quota before submitting its real summary.

  • Allow jq for JSON payload preparation.
  • Prohibit diagnostic/placeholder writes and direct argument discovery to --help.
  • Clarify item_number targeting and stop repeated denied-command retries.
  • Regenerate the lock file using repository-pinned gh-aw v0.88.2.

Preserves comment limits, label restrictions, triggers, and GitHub permissions. No runtime/API changes.

Issues

Fixes #4692. Affected triage target: #4691.

Testing

gh aw compile succeeded with zero warnings; a second compile left the lock file unchanged. Generated permissions include shell(jq). git diff --check passed. No application tests added because only workflow configuration and instructions change. Fixed live execution is pending merge.

After merge, a maintainer should post /triage on #4691 and verify one complete summary and no report_incomplete. The erroneous test comment has not been deleted.

Guidelines

  • Tests added or updated (workflow compilation checks performed; no application tests applicable)
  • Public API changes documented (none)
  • Verified against customer repro (original run inspected; fixed live run pending)
  • Ensure no breaking changes introduced

Allow jq for the documented JSON payload path and prohibit diagnostic comment writes that consume the single-comment quota.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The documented JSON-mode submission command does not provide the generated payload on stdin.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

Fixes issue auto-triage output preparation and prevents placeholder comments from consuming the comment quota.

Changes:

  • Allows jq for JSON payload construction.
  • Adds safe-output usage guardrails.
  • Regenerates the pinned workflow lock file.
File summaries
File Description
.github/workflows/issue-triage.md Adds jq and safe-output instructions.
.github/workflows/issue-triage.lock.yml Regenerates workflow permissions and metadata.
Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 1
  • Review effort level: Balanced

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

the allowance. The target argument is `item_number`, not `issue_number`.
For a multi-line summary saved to a temporary file, use the allowed `jq -Rs`
command to construct the JSON payload with `item_number` and `body`, then
submit it once through `safeoutputs add_comment .`.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: To triage

Development

Successfully merging this pull request may close these issues.

[aw] SqlClient Issue Auto-Triage reported incomplete result

5 participants