Repository navigation
[7.1.2 Cherry-pick] Add XML documentation validation to OneBranch builds and fix docs issues - #4800
Merged
Merged
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
paulmedynski
force-pushed
the
dev/automation/pr-4730-to-7.1.2
branch
from
October 7, 2026 11:59
100daed to
bf2175b
Compare
Contributor
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
paulmedynski
approved these changes
Oct 7, 2026
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The array validation rejects valid dimensions whose lower bound is omitted but size is specified.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Backports XML documentation validator hardening and corrects an invalid method reference.
Changes:
- Validates malformed generic, array, and parameter syntax.
- Adds regression coverage for valid and invalid DocIDs.
- Corrects the
DbDataAdapter.Update(DataSet)cref prefix.
| File | Description |
|---|---|
validate-xml-docs.ps1 |
Strengthens DocID validation. |
validate-xml-docs.Tests.ps1 |
Adds validator regression tests. |
SqlRowUpdatingEventArgs.xml |
Corrects an event prefix to a method prefix. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/7.1 #4800 +/- ##
===============================================
- Coverage 66.52% 64.36% -2.16%
===============================================
Files 291 285 -6
Lines 45101 68065 +22964
===============================================
+ Hits 30002 43813 +13811
- Misses 15099 24252 +9153
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
cheenamalhotra
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Backports the remaining changes from #4730 to
release/7.1for 7.1.2. Most XML documentation validation infrastructure was already backported in #4752; this PR contains only the additional validator hardening, regression tests, and documentation correction.SqlRowUpdatingEventArgsreference toDbDataAdapter.Update(DataSet)from an event (E:) to a method (M:).Issues
Testing