Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Reviewer's GuideThe PR adds net11.0 support and makes the .NET 11 preview SDK the pinned development, CI, packaging, and container baseline, while conditionally adopting EditContext.ValidateAsync for .NET 11 and updating affected component tests to await asynchronous helpers; earlier target frameworks remain supported. Sequence diagram for framework-specific asynchronous form validationsequenceDiagram
participant Caller
participant ValidateForm
participant Validator
participant EditContext
Caller->>ValidateForm: ValidateAsync(cancellationToken)
ValidateForm->>Validator: ValidateAsync(cancellationToken)
alt .NET 11 or later
Validator->>EditContext: ValidateAsync(cancellationToken)
EditContext-->>Validator: Task<bool>
else Earlier target frameworks
Validator->>EditContext: validation event path
EditContext-->>Validator: validation result
end
Validator-->>ValidateForm: Task<bool>
ValidateForm-->>Caller: Task<bool>
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![bb-auto[bot]](https://avatars.githubusercontent.com/in/287253?s=60&v=4){kind=small}
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey - I've reviewed your changes and they look great!
Sourcery assessment
Needs a human reviewer. This changes the production container from the .NET 10 runtime to a .NET 11 preview runtime and changes the application target framework and validation behavior, so an incompatibility could prevent deployment or cause an outage. Reverting restores the prior images and target, but any failed deployment or outage would already have occurred.
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8406 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 771 771
Lines 34616 34616
=========================================
Hits 34616 34616
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This reverts commit e6130f1. # Conflicts: # src/BootstrapBlazor/Components/ValidateForm/BootstrapBlazorDataAnnotationsValidator.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #8405
Summary By Copilot
net11.0to the supported target frameworks and pin the .NET 11 preview SDK inglobal.json.EditContext.ValidateAsyncAPI while retaining the existing validation path for earlier frameworks.Regression?
The existing
net6.0throughnet10.0target frameworks remain configured.Risk
The default development target, CI SDK, container images, and validation API path move to a preview framework. Earlier target frameworks keep their existing conditional implementation.
Verification
dotnet test test\UnitTest\UnitTest.csproj -f net11.0 --nologo --verbosity quietAll 2570 tests passed.
Packaging changes reviewed?
The package project adds
net11.0and the corresponding .NET 11 preview package references while retaining all existing target frameworks.☑️ Self Check before Merge
Summary by Sourcery
Add .NET 11 preview support across targeting, validation, CI, packaging, and container environments while preserving compatibility with earlier frameworks.
New Features:
Enhancements:
Build:
CI:
Deployment:
Tests: