docs: the egui bump is blocked on one upstream release, not on an investigation - #523
Merged
Merged
Conversation
…estigation `AGENTS.md` said the egui 0.36 / wgpu 30 migration was "blocked upstream" and gave no tracking anchor, so the only way to learn whether it was still blocked was to re-derive it. Re-measured 2026-09-18, and the answer changed. The blocker is fixed upstream. PR emilk/egui#8516, "Fix egui-winit compilation on wasm32", merged 2026-09-07 into `main`, gating `mod dropped_file;` behind `cfg(not(target_arch = "wasm32"))`. It is in NO published version: 0.36.2 shipped 2026-09-08, the day AFTER that merge, without it. Both ends were verified by COMPILING rather than by reading changelogs -- a throwaway crate carrying this project's exact feature set fails on 0.36.2 with the identical E0407 and finishes clean against rev da7169ed. So the unblock condition is a version rather than an open question: the first published egui-winit whose `src/lib.rs` gates that module, expected 0.36.3 or 0.37. FOUR TRAPS ARE RECORDED, because each one produced a wrong conclusion during this measurement and would produce it again. The fix is in `lib.rs` and NOT in the file the compiler names. `dropped_file.rs` still carries the unconditional `impl` on upstream `main`, so reading the file the error points at reads as "still broken" while it is fixed one level up. That is the same shape as this project's own recurring finding that a gate can be blind to its subject. `emilk/egui`'s default branch is `main`, and a stale `master` ref also exists and answers raw.githubusercontent.com, so fetching `master` silently describes the wrong tree. Verifying the reference, not just the file. A `[patch.crates-io]` to that rev is silently IGNORED against a `0.36.2` requirement: the rev declares `0.36.1`, does not satisfy `^0.36.2`, and cargo drops the patch and builds the registry copy while the error still names the registry path -- which reads exactly like the patch having been applied and the fix not working. And using the rev at all is refused by this project's own policy. `deny.toml` sets `unknown-git = "deny"` with `allow-git = []`, and `Cargo.lock` carries zero git-sourced packages, so landing early means widening the supply-chain policy in a project that SHA-pins its actions and keeps one toolchain source of truth. Examined and deliberately NOT taken: the concession buys weeks against a real reproducibility cost, and the release carries the fix anyway. Also recorded for when it lands: the branch is the ONLY copy of the migration (`main` is egui 0.35 / wgpu 29, so deleting it destroys the work), it was cut at v2.3.2 against a `main` now at v2.6.19 and needs rebasing, and the bump is atomic -- `egui-wgpu` 0.36 requires wgpu 30, so egui/egui-wgpu/egui-winit/wgpu/ naga move together or the graph holds wgpu 29 and 30 at once. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014qfTKi2M3swo7qnwvYCkDj
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Antigravity review (Gemini via Ultra)This PR adds documentation to Blocking issuesNone found. Suggestions
Nitpicks
Automated first-pass review by |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AGENTS.mdsaid the egui 0.36 / wgpu 30 migration was "blocked upstream" with no tracking anchor — so the only way to learn whether it was still blocked was to re-derive it. Re-measured 2026-09-18, and the answer changed.The blocker is fixed upstream, and unreleased
emilk/egui PR #8516, "Fix egui-winit compilation on wasm32", merged 2026-09-07 into
main, gatingmod dropped_file;behindcfg(not(target_arch = "wasm32")).mod dropped_file;E0407main@da7169ed0.36.2 shipped the day after the merge without it. Both ends verified by compiling a throwaway crate with this project's exact feature set, not by reading changelogs.
So the unblock condition is a version, not an open question: the first published
egui-winitwhosesrc/lib.rsgates that module — expect 0.36.3 or 0.37.Four traps recorded
Each produced a wrong conclusion during this measurement:
lib.rs, not the file the error names.dropped_file.rsstill carries the unconditionalimplonmain, so reading the cited file reads as "still broken".emilk/egui's default branch ismain; a stalemasterref also answers raw.githubusercontent.com and describes the wrong tree.[patch.crates-io]to that rev is silently ignored against a0.36.2requirement — the rev declares0.36.1, cargo drops the patch and builds the registry copy while the error still names the registry path.deny.tomlrefuses git sources (unknown-git = "deny",allow-git = [], 0 git packages inCargo.lock), so landing early means widening supply-chain policy. Examined and deliberately not taken.For when it lands
The branch is the only copy (
mainis egui 0.35 / wgpu 29 — deleting it destroys the work), it was cut at v2.3.2 against amainnow at v2.6.19 so it needs rebasing, and the bump is atomic:egui-wgpu0.36 requires wgpu 30.Gates: markdownlint clean,
release_anchor_audit13/13. Docs-only.🤖 Generated with Claude Code
https://claude.ai/code/session_014qfTKi2M3swo7qnwvYCkDj