Repository navigation
Updated Drupal contrib modules and pinned 'phpstan/phpstan' to '<=2.3.3' to unblock Rector. #3245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file has 3 constraint changes.
composer.lockisn't committed in this repo, so the floors and caps here are what every fresh install and consumer site actually resolves against.drupal/stage_file_proxy^4.0.0->^4.0.1- security release, SA-CONTRIB-2026-286 (critical XSS, CVE-2026-118576). Fallback file retrieval in 4.0.0 doesn't check the fetched file URL for malicious content, so it's exploitable when an attacker can place a file on the configured origin. Raising the floor means no install can resolve 4.0.0. The template enables the module outside production only, which limits exposure, but this should still land promptly. Release notes: https://www.drupal.org/project/stage_file_proxy/releases/4.0.1. Besides the security fix it adds WebP support and non-image URL rewriting; no update hooks or config changes.drupal/search_api^1.42.0->^1.43.0- routine release, no advisory. It fixes cache contexts set in Views cache plugins, which could poison search result caches. Release notes: https://www.drupal.org/project/search_api/releases/8.x-1.43. No schema or config changes, but sites should clear caches after deploying so result cache entries from before the update are dropped.phpstan/phpstan^2.3.1-><=2.3.3- temporary pin, tracked in #3244. PHPStan 2.3.4 uses thephpdoc-parser2.4 API, but Rector autoloads its own bundled 2.3 copy first, soahoy lintcrashes on Rector for every file (rectorphp/rector#9947, fix in progress at rectorphp/rector-src#8883). A newer Rector can't help yet: every release is affected, andpalantirnet/drupal-rector1.1.3 holds Rector below 2.6.2 (palantirnet/drupal-rector#420). It's written as<=2.3.3rather than^2.3.1 <2.3.4because the installer's snapshot normaliser only reduces single-token constraints to__VERSION__. A range would change every installer fixture. When #3244 removes the pin, a plain caret constraint is safe for the same reason.