Repository navigation
fix: compare inclusion dates in the schedule's time zone - #175
Merged
Merged
Conversation
The missed-inclusion check compared inclusion dates with the UTC date. West of UTC an inclusion date became due at UTC midnight, the local evening before, where the schedule.time gate did not apply, so IRREGULAR_SCHEDULE_MISSED fired early and its once-per-date marker then suppressed the alert for a real miss. East of UTC it waited for UTC midnight. PastInclusionDates now takes the location and compares with today's date in schedule.timezone, the same zone the time gate uses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The watchdog's missed-inclusion check compared inclusion dates with the UTC date. With
schedule.timezoneAmerica/New_York and an inclusion date of 2026-03-31, the date became due at 2026-03-31T00:00Z, 20:00 the evening before in New York. Theschedule.timegate applies only when the date is today in the schedule's zone, so it did not hold the alert back:IRREGULAR_SCHEDULE_MISSEDwas published early, and its once-per-date marker then kept the alert from being sent for a real miss the next day. East of UTC the check waited for UTC midnight instead.PastInclusionDatestakes a location and compares with today's date inschedule.timezone(UTC when unset), the same zone theschedule.timegate and the exclusion check use.schedule.timewhen it is set, at local midnight of the date otherwise. The docs say so and recommend settingtimeto avoid an alert before the run is due.