Skip to content

[patch] Remove localization errors in v17.1.0 #2539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jialecl merged 5 commits into from
Sep 11, 2026
Merged

[patch] Remove localization errors in v17.1.0 #2539

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a454895
Remove localization errors in v17.1.0
PelayoFelgueroso Sep 11, 2026
e3c92e1
Merge branch 'jialecl/v17.1.0' into pfelgueroso/messsageInput-v17.1.0
Jialecl Sep 11, 2026
9ac5ec3
fix test errors
PelayoFelgueroso Sep 11, 2026
f6d705a
fix errors
PelayoFelgueroso Sep 11, 2026
1cf875e
fix based on comments
PelayoFelgueroso Sep 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions packages/lib/src/message-input/MessageInput.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,23 +186,23 @@ describe("Message Input component tests", () => {
fireEvent.change(input, { target: { value: "test" } });
expect(onChange).toHaveBeenCalledWith({
value: "test",
error: "The minimum length is 5.",
error: "Min length 5, max length 10.",
});
fireEvent.blur(input);
expect(onBlur).toHaveBeenCalledWith({
value: "test",
error: "The minimum length is 5.",
error: "Min length 5, max length 10.",
});

fireEvent.change(input, { target: { value: "test-maximum-length" } });
expect(onChange).toHaveBeenCalledWith({
value: "test-maximum-length",
error: "The maximum length is 10.",
error: "Min length 5, max length 10.",
});
fireEvent.blur(input);
expect(onBlur).toHaveBeenCalledWith({
value: "test-maximum-length",
error: "The maximum length is 10.",
error: "Min length 5, max length 10.",
});

fireEvent.change(input, { target: { value: "length" } });
Expand Down Expand Up @@ -435,7 +435,7 @@ describe("useVoiceTranscription", () => {
});

test("resets transcript and isRecording when recognition ends automatically", () => {
const { result } = renderHook(() => useVoiceTranscription({ lang: "eb-US" }));
const { result } = renderHook(() => useVoiceTranscription({ lang: "en-US" }));

act(() => {
result.current.startRecording();
Expand Down
52 changes: 24 additions & 28 deletions packages/lib/src/message-input/MessageInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ import { HalstackLanguageContext } from "../HalstackContext";
import ErrorMessage from "../styles/forms/ErrorMessage";
import { useVoiceTranscription } from "./useVoiceTranscription";
import DxcSelect from "../select/Select";
import { getLengthErrorMessage } from "../common/utils";
import DxcTypography from "../typography/Typography";

const sizes = {
Expand Down Expand Up @@ -143,9 +142,8 @@ const DxcMessageInput = ({
tabIndex,
value,
}: PromptInputPropsType) => {
const languageContext = useContext(HalstackLanguageContext);
const translatedLabels = languageContext.labels;
const locale = languageContext.locale ?? "en-US";
const translatedLabels = useContext(HalstackLanguageContext);
const locale = "en-US";
const inputId = `input-${useId()}`;
const inputRef = useRef<HTMLTextAreaElement | null>(null);
const overlayRef = useRef<HTMLDivElement | null>(null);
Expand All @@ -162,18 +160,17 @@ const DxcMessageInput = ({
} = useVoiceTranscription({
lang: locale,
});
const dropdownOptions = [{ label: languageContext.labels.messageInput.attachFileButtonTitle, value: "fileorphoto" }];
const dropdownOptions = [{ label: translatedLabels.messageInput.attachFileButtonTitle, value: "fileorphoto" }];

const changeValue = (newValue: string) => {
if (value == null) setInnerValue(newValue);

const lengthError = getLengthErrorMessage({
value: newValue,
minLength,
maxLength,
minLengthErrorMessage: translatedLabels.formFields.minLengthErrorMessage,
maxLengthErrorMessage: translatedLabels.formFields.maxLengthErrorMessage,
});
let lengthError: string | undefined;
if (minLength != null && newValue.length < minLength) {
lengthError = translatedLabels.formFields.lengthErrorMessage?.(minLength, maxLength);
} else if (maxLength != null && newValue.length > maxLength) {
lengthError = translatedLabels.formFields.lengthErrorMessage?.(minLength, maxLength);
}

if (lengthError) {
onChange?.({ value: newValue, error: lengthError });
Expand All @@ -199,13 +196,12 @@ const DxcMessageInput = ({
const handleInputOnBlur = (event: FocusEvent<HTMLTextAreaElement>) => {
setIsFocused(false);

const lengthError = getLengthErrorMessage({
value: event.target.value,
minLength,
maxLength,
minLengthErrorMessage: translatedLabels.formFields.minLengthErrorMessage,
maxLengthErrorMessage: translatedLabels.formFields.maxLengthErrorMessage,
});
let lengthError: string | undefined;
if (minLength != null && event.target.value.length < minLength) {
lengthError = translatedLabels.formFields.lengthErrorMessage?.(minLength, maxLength);
} else if (maxLength != null && event.target.value.length > maxLength) {
lengthError = translatedLabels.formFields.lengthErrorMessage?.(minLength, maxLength);
}

if (lengthError) {
onBlur?.({ value: event.target.value, error: lengthError });
Expand Down Expand Up @@ -326,7 +322,7 @@ const DxcMessageInput = ({
)}
<InputWrapper>
<MessageArea
aria-label={languageContext.labels.messageInput.inputAriaLabel}
aria-label={translatedLabels.messageInput.inputAriaLabel}
aria-errormessage={error ? `error-${inputId}` : undefined}
aria-invalid={!!error}
disabled={isGenerating || disabled}
Expand Down Expand Up @@ -390,13 +386,13 @@ const DxcMessageInput = ({
onClick={toggleVoiceRecognition}
title={
isRecording
? languageContext.labels.messageInput.stopRecordingButtonTitle
: languageContext.labels.messageInput.recordAudioButtonTitle
? translatedLabels.messageInput.stopRecordingButtonTitle
: translatedLabels.messageInput.recordAudioButtonTitle
}
aria-label={
isRecording
? languageContext.labels.messageInput.stopRecordingButtonTitle
: languageContext.labels.messageInput.recordAudioButtonTitle
? translatedLabels.messageInput.stopRecordingButtonTitle
: translatedLabels.messageInput.recordAudioButtonTitle
}
/>
)}
Expand All @@ -408,13 +404,13 @@ const DxcMessageInput = ({
onClick={!isGenerating ? handleSubmit : handleStop}
title={
!isGenerating
? languageContext.labels.messageInput.sendButtonTitle
: languageContext.labels.messageInput.stopButtonTitle
? translatedLabels.messageInput.sendButtonTitle
: translatedLabels.messageInput.stopButtonTitle
}
aria-label={
!isGenerating
? languageContext.labels.messageInput.sendButtonTitle
: languageContext.labels.messageInput.stopButtonTitle
? translatedLabels.messageInput.sendButtonTitle
: translatedLabels.messageInput.stopButtonTitle
}
/>
</DxcFlex>
Expand Down
Loading