Repository navigation
Fix Spearman correlation of CSR and symmetric input - #37
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
spearman_rank_sparse()assumed its input was a general CSC matrix, socalculate_similarity()andcalculate_distance()silently returned wrong Spearman correlations for:dgRMatrix(e.g. CSR from anndata): ranked along the wrong axis, also when called viadynutils:::spearman_rank_sparse()as in Fix CSR Spearman scores and pbmc_multiome failures, add a seed to all methods openproblems-bio/task_predict_modality#83as(x, "CsparseMatrix")turns it into adsCMatrix, which only stores one triangle)dgTMatrix, which errored because it has no@pslotChanges:
.process_input_matrices()converts all inputs to adgCMatrixwhose columns are the vectors to compare. For adgRMatrixwithmargin = 1it reuses the slots as-is, so no transpose is needed.spearman_rank_sparse()uses the same conversion.Runtime is unchanged.