Repository navigation
fix: address review follow-ups for sources, git transport and Trae commands - #3468
Merged
Merged
Conversation
…mmands - Document that an empty `skills`/`rules` list fails only its own source, in `--frozen` mode too, while the other sources are still installed. - Share one empty-selection predicate between the frozen lockfile check and the per-source empty-list error. - Skip `.git` case-insensitively in the git transport walk, matching the start-directory check. - Warn when Trae commands derive the same `name` (Trae documents it as a unique identifier) and when project commands are nested deeper than the three levels Trae reads. - Rewrap the OpenHands watchlist entry. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012y9fNo2AAJdGocxvsHtDhv
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012y9fNo2AAJdGocxvsHtDhv
- Derive the Trae `name` through one helper in both generation and the duplicate-name warning; a non-string `trae.name` still fails validation. - Test that CommandsProcessor passes the scope to the Trae checks, so global commands get no nesting warning. - Note why the git transport walk skips `.git` case-insensitively. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012y9fNo2AAJdGocxvsHtDhv
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012y9fNo2AAJdGocxvsHtDhv
…rap-followups # Conflicts: # src/generated/docs-content.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-ups from the #3456, #3457, #3459 and #3460 reviews tracked in #3461. Each item is either fixed here or shown to need no change.
docs/guide/declarative-sources.md. An emptyskills/ruleslist fails only the source that declares it, in--frozenmode too. The other sources are still installed into.curated/, and theninstallexits with an error that counts the failed sources. This is how non-frozen installs already behave, so the behavior is kept and documented instead of adding an up-front abort.hasEmptySelectionandassertNonEmptySelectionsnow sharegetEmptySelections.agents/<name>.md, where "the file name (without.md) becomes the profile's identifier" andnamedefaults to the file or directory name.descriptionhas no default and nothing is documented as required. So Devin itself loads.devin/agents/README.mdas a profile namedREADME, and importing it the same way matches what Devin does. Skipping it would hide a profile that Devin actually loads.TraeCommand.validateRulesyncCommandsnow warns when two commands targeted at Trae end up with the samename: the file stem, ortrae.nameif that is set. The Trae commands docs callname"the unique identifier for the command".validateRulesyncCommandshook now also receivesglobal. The Trae note indocs/reference/file-formats.mdmentions both warnings..gitskip (fix(sources): refuse skill paths resolving into .git and address review follow-ups #3460): the git transport walk now skips.gitwithout regard to case, matching the start-directory check. The test now covers.git,.GITand.Git.Closes #3461
Test plan
pnpm cicheckTraeCommand.validateRulesyncCommandstests: duplicate stems, atrae.nameoverride, non-Trae targets ignored, the depth limit, and global mode left unchecked.gitskip test🤖 Generated with Claude Code
https://claude.ai/code/session_012y9fNo2AAJdGocxvsHtDhv