Skip to content

Make Sampler completely Fitter-agnostic - #310

Open
rozyczko wants to merge 1 commit into
sampler-engine-structure-280from
280-more-refactoring
Open

rozyczko wants to merge 1 commit into
sampler-engine-structure-280from
280-more-refactoring

Conversation

@rozyczko

Copy link
Copy Markdown
Member

Addressing @damskii9992's issue in #287 (comment)

Made Sampler fully Fitter-independent.

This is a separate PR on top of #287 to allow for easier review.

@rozyczko rozyczko added [scope] maintenance Code/tooling cleanup, no feature or bugfix (major.minor.PATCH) [priority] high Should be prioritized soon [area] base classes Changes to or creation of new base classes labels Sep 17, 2026
@codecov

codecov Bot commented Sep 17, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.18182% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.82%. Comparing base (82a1b01) to head (5f8bd2f).

Files with missing lines Patch % Lines
src/easyscience/fitting/reshaping.py 96.61% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                       Coverage Diff                        @@
##           sampler-engine-structure-280     #310      +/-   ##
================================================================
+ Coverage                         83.64%   83.82%   +0.17%     
================================================================
  Files                                68       69       +1     
  Lines                              5266     5285      +19     
================================================================
+ Hits                               4405     4430      +25     
+ Misses                              861      855       -6     
Flag Coverage Δ
unittests 83.82% <98.18%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/easyscience/fitting/fitter.py 96.03% <100.00%> (+4.70%) ⬆️
src/easyscience/fitting/multi_fitter.py 100.00% <100.00%> (+1.38%) ⬆️
src/easyscience/fitting/sampler.py 100.00% <100.00%> (ø)
src/easyscience/fitting/reshaping.py 96.61% <96.61%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[area] base classes Changes to or creation of new base classes [priority] high Should be prioritized soon [scope] maintenance Code/tooling cleanup, no feature or bugfix (major.minor.PATCH)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant