Skip to content

Show interactive spin arrows - #415

Open
rozyczko wants to merge 2 commits into
developfrom
show-spin
Open

rozyczko wants to merge 2 commits into
developfrom
show-spin

Conversation

@rozyczko

Copy link
Copy Markdown
Member

Magnetism vector representation and marker extraction:

  • Added magnetic_vector_for_layer(magnetism), which computes a detailed dictionary describing a layer's in-plane magnetic moment, including both parameter and physical angles, magnitude, and channel components. This ensures all arrow visualizations use a single, well-defined convention.
  • Introduced Project.magnetic_layer_markers_for_model_at_index(index), which returns a list of marker dictionaries for each magnetic layer in a model, including their depth extents, moment vectors, and a boolean indicating if the moment is significant. This method handles stack order, repeat expansion, and corrects for profile padding and reversal, ensuring accurate placement and annotation of magnetic layers.

@rozyczko rozyczko added [scope] enhancement Adds/improves features (major.MINOR.patch) [priority] high Should be prioritized soon enhancement labels Sep 16, 2026
@codecov

codecov Bot commented Sep 16, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.22222% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 94.59%. Comparing base (ad7d255) to head (bf5c4e4).

Files with missing lines Patch % Lines
src/easyreflectometry/project.py 97.22% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #415      +/-   ##
===========================================
+ Coverage    94.57%   94.59%   +0.01%     
===========================================
  Files           54       54              
  Lines         5515     5551      +36     
===========================================
+ Hits          5216     5251      +35     
- Misses         299      300       +1     
Flag Coverage Δ
integration 38.13% <8.33%> (-0.20%) ⬇️
unittests 94.59% <97.22%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/easyreflectometry/project.py 94.46% <97.22%> (+0.09%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement [priority] high Should be prioritized soon [scope] enhancement Adds/improves features (major.MINOR.patch)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant