Skip to content

fix: identify Pulse Check metrics as sample data - #140

Merged
johnnyhuy merged 1 commit into
mainfrom
agent/issue-139-pulse-check-sample-data
Nov 14, 2026
Merged

johnnyhuy merged 1 commit into
mainfrom
agent/issue-139-pulse-check-sample-data

Conversation

@johnnyhuy

Copy link
Copy Markdown
Contributor

Pulse Check now identifies its dashboard as sample data and explains that catalog service names are combined with simulated health and uptime, example incidents and example deployment metrics. The notice stays visible during loading, catalog errors and empty results, and the subtitle describes the demonstration honestly.

Part of #85. Closes #139. The parent epic remains open.

Verified locally with the repository tasks.

  • mise run install passed with peer dependency warnings.
  • mise run lint passed, including TypeScript and ESLint across all workspaces.
  • mise run test --runInBand --verbose passed with 50 tests in eight suites. One existing test and suite remain skipped. Jest emitted CSS parsing and React deprecation warnings.
  • BROWSER=none mise run dev compiled successfully and served the frontend on localhost:3000 and backend on localhost:7007.
  • mise run proof-browser -- open http://localhost:3000/pulse-check --browser=chrome, followed by Guest > Enter, rendered the notice above the populated dashboard. This was a temporary local mise task wrapping the installed Playwright CLI.
  • mise run proof-browser -- resize 1440 1100 and mise run proof-browser -- screenshot --filename=.tmp/proof/issue-139-pulse-check.png --full-page captured the changed surface. The screenshot was visually inspected.
  • The worktree was trusted for these commands using MISE_TRUSTED_CONFIG_PATHS. This slice changes only frontend copy and its tests, so a Docker image build was not required.

The new regression tests passed with the actual dashboard components.

PASS app packages/app/src/components/pulse-check/PulseCheckPage.test.tsx (5.177 s)
  ✓ identifies simulated health and fixture metrics on the populated dashboard (143 ms)
  ✓ keeps the sample-data notice visible while services load (36 ms)
  ✓ keeps the sample-data notice visible when the catalog fails (36 ms)
  ✓ identifies example metrics even when the catalog has no services (72 ms)
Test Suites: 1 skipped, 8 passed, 8 of 9 total
Tests:       1 skipped, 50 passed, 51 total

Browser capture succeeded. No capture path was blocked and no evidence fallback was needed. The screenshot is committed and pinned to the reviewed commit.

Pulse Check sample-data notice above the example dashboard

The dashboard still uses demonstration data. Connecting monitoring providers remains a separate slice. Runtime logs still show a Signals websocket 404 and unavailable TechDocs search indexes, also recorded on earlier PRs; these did not block the guest dashboard capture and remain outside this slice.

Co-authored-by: OpenAI Codex <noreply@openai.com>
@johnnyhuy
johnnyhuy merged commit e840211 into main Nov 14, 2026
5 checks passed
@johnnyhuy
johnnyhuy deleted the agent/issue-139-pulse-check-sample-data branch November 14, 2026 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Identify Pulse Check metrics as sample data

1 participant