Repository navigation
fix: identify Pulse Check metrics as sample data - #140
Merged
Merged
Conversation
Co-authored-by: OpenAI Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pulse Check now identifies its dashboard as sample data and explains that catalog service names are combined with simulated health and uptime, example incidents and example deployment metrics. The notice stays visible during loading, catalog errors and empty results, and the subtitle describes the demonstration honestly.
Part of #85. Closes #139. The parent epic remains open.
Verified locally with the repository tasks.
mise run installpassed with peer dependency warnings.mise run lintpassed, including TypeScript and ESLint across all workspaces.mise run test --runInBand --verbosepassed with 50 tests in eight suites. One existing test and suite remain skipped. Jest emitted CSS parsing and React deprecation warnings.BROWSER=none mise run devcompiled successfully and served the frontend on localhost:3000 and backend on localhost:7007.mise run proof-browser -- open http://localhost:3000/pulse-check --browser=chrome, followed by Guest > Enter, rendered the notice above the populated dashboard. This was a temporary local mise task wrapping the installed Playwright CLI.mise run proof-browser -- resize 1440 1100andmise run proof-browser -- screenshot --filename=.tmp/proof/issue-139-pulse-check.png --full-pagecaptured the changed surface. The screenshot was visually inspected.MISE_TRUSTED_CONFIG_PATHS. This slice changes only frontend copy and its tests, so a Docker image build was not required.The new regression tests passed with the actual dashboard components.
Browser capture succeeded. No capture path was blocked and no evidence fallback was needed. The screenshot is committed and pinned to the reviewed commit.
The dashboard still uses demonstration data. Connecting monitoring providers remains a separate slice. Runtime logs still show a Signals websocket 404 and unavailable TechDocs search indexes, also recorded on earlier PRs; these did not block the guest dashboard capture and remain outside this slice.