Repository navigation
fix: make Scorecard filters accessible and recoverable - #146
Merged
Merged
Conversation
Co-authored-by: OpenAI Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scorecard now names its search, Kind and Type controls, announces the matching entity count, and offers Clear filters whenever a filter is active. Search ignores surrounding whitespace and letter case; clearing restores all scorecards and returns focus to search while the catalog-wide overview stays unchanged.
Part of #85
Closes #145
Verified in this worktree
mise run installpassed with existing peer-dependency warnings and no lockfile changes. The reviewed worktree config neededMISE_TRUSTED_CONFIG_PATHS="$PWD"for mise tasks.mise run lintpassed TypeScript and ESLint across all five workspaces.mise run test -- --runInBand --verbosepassed 65 tests in 10 suites, with one existing skipped test and suite.BROWSER=none mise run devcompiled and served the app on localhost:3000 and backend on localhost:7007. Playwright entered as Guest, opened/scorecard, searched for a missing entity, then cleared the filters. The browser restored all 22 demo entities and the active element was the search input.git diff --checkpassed.mise run buildwas not run locally because this slice changes frontend controls and tests only. The PR Build workflow includes the Docker build.The four added regression cases passed
Capture method (a) succeeded. These 1440 by 1200 PNGs are from the running worktree after guest entry, saved under
.tmp/proof/. No capture path was blocked.The overview deliberately continues to describe the full catalog, as the existing empty-filter regression requires. Existing React/MUI deprecation and jsdom stylesheet warnings appeared during verification, and the preview signals WebSocket still returns 404. They did not prevent the Scorecard checks or capture. Backend behaviour, scoring rules and catalog data are unchanged. The parent epic remains open; demo-baseline and landing-page taste decisions remain with Johnny.