Repository navigation
fix: let visitors retry failed Scorecard loads - #148
Merged
Merged
Conversation
Co-authored-by: OpenAI Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scorecard now offers Retry after a failed catalog load and announces loading while the next request is pending. Success restores the scorecards or the existing empty-catalog message; another failure keeps recovery available.
Part of #85
Closes #147
Verified in this worktree
MISE_TRUSTED_CONFIG_PATHS="$PWD" mise run installpassed with existing peer-dependency warnings and no lockfile changes.MISE_TRUSTED_CONFIG_PATHS="$PWD" mise run lintpassed TypeScript and ESLint across all five workspaces.MISE_TRUSTED_CONFIG_PATHS="$PWD" mise run test -- --runInBand --verbosepassed 68 tests in 10 suites, with one existing skipped test and suite.BROWSER=none MISE_TRUSTED_CONFIG_PATHS="$PWD" mise run devcompiled successfully and initialised the backend plugins./scorecardreturned HTTP 200. The dev stack was stopped after verification.git diff --checkpassed.mise run buildwas not run locally because this slice changes frontend controls and tests only.mise run install,mise run lint,mise run testandmise run build, including the Docker image build. All PR checks are green.Capture method (a) was blocked when Playwright Chrome failed to launch within its 180000 ms timeout. No screenshot was captured, and browser rendering remains unverified. Method (b) succeeded with the regression-test output below. The verification transcript contains the Scorecard test results, suite totals, lint output and dev-server checks.
The three added regression cases passed
The pending-request test verifies that the old alert and Retry button disappear while loading, then checks the restored metrics and entity card. The repeated-failure test checks the new error and a later empty-catalog recovery. Existing jsdom stylesheet and React/MUI warnings appeared during the suite.
The parent epic stays open. A browser capture of failure and recovery remains a follow-up when Chrome can launch; public-demo baseline and landing-page taste decisions remain with Johnny.