Skip to content

fix: let visitors retry failed Scorecard loads - #148

Merged
johnnyhuy merged 1 commit into
mainfrom
agent/issue-147-scorecard-retry
Nov 16, 2026
Merged

johnnyhuy merged 1 commit into
mainfrom
agent/issue-147-scorecard-retry

Conversation

@johnnyhuy

@johnnyhuy johnnyhuy commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Scorecard now offers Retry after a failed catalog load and announces loading while the next request is pending. Success restores the scorecards or the existing empty-catalog message; another failure keeps recovery available.

Part of #85
Closes #147

Verified in this worktree

  • MISE_TRUSTED_CONFIG_PATHS="$PWD" mise run install passed with existing peer-dependency warnings and no lockfile changes.
  • MISE_TRUSTED_CONFIG_PATHS="$PWD" mise run lint passed TypeScript and ESLint across all five workspaces.
  • MISE_TRUSTED_CONFIG_PATHS="$PWD" mise run test -- --runInBand --verbose passed 68 tests in 10 suites, with one existing skipped test and suite.
  • BROWSER=none MISE_TRUSTED_CONFIG_PATHS="$PWD" mise run dev compiled successfully and initialised the backend plugins. /scorecard returned HTTP 200. The dev stack was stopped after verification.
  • git diff --check passed.
  • mise run build was not run locally because this slice changes frontend controls and tests only.
  • The CI Build workflow passed mise run install, mise run lint, mise run test and mise run build, including the Docker image build. All PR checks are green.

Capture method (a) was blocked when Playwright Chrome failed to launch within its 180000 ms timeout. No screenshot was captured, and browser rendering remains unverified. Method (b) succeeded with the regression-test output below. The verification transcript contains the Scorecard test results, suite totals, lint output and dev-server checks.

The three added regression cases passed

PASS app packages/app/src/components/scorecard/ScorecardPage.test.tsx (17.797 s)
  ✓ retries a failed catalog load and shows scorecards after a pending request (219 ms)
  ✓ offers another retry after a second failure and handles an empty recovery (217 ms)
  ✓ offers retry when the catalog rejects without an Error object (54 ms)

Test Suites: 1 skipped, 10 passed, 10 of 11 total
Tests:       1 skipped, 68 passed, 69 total

The pending-request test verifies that the old alert and Retry button disappear while loading, then checks the restored metrics and entity card. The repeated-failure test checks the new error and a later empty-catalog recovery. Existing jsdom stylesheet and React/MUI warnings appeared during the suite.

The parent epic stays open. A browser capture of failure and recovery remains a follow-up when Chrome can launch; public-demo baseline and landing-page taste decisions remain with Johnny.

Co-authored-by: OpenAI Codex <noreply@openai.com>
@johnnyhuy
johnnyhuy merged commit b182498 into main Nov 16, 2026
5 checks passed
@johnnyhuy
johnnyhuy deleted the agent/issue-147-scorecard-retry branch November 16, 2026 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Let visitors retry failed Scorecard catalog loads

1 participant