Skip to content

Add entry-aware catalogue equipment swap suggestions #81

Closed

Description

@johnnyhuy

Part of #5. Continues the catalogue suggestions in #76 and entry-specific application in #79.

Add a core package suggestion result carrying the WorkoutExercise.id alongside the original exercise and catalogue alternatives, and an EquipmentSwapManager.suggestEntrySwaps(for:from:) API returning these results in workout order.

  • Keep repeated exercise definitions addressable as separate workout entries.
  • Preserve catalogue matching, ordering, identity and metadata rules.
  • Keep the existing tuple suggestion APIs compatible, sharing the catalogue selection path.
  • Prove a suggestion for the second repeated entry can be passed to applySwap(workout:workoutExerciseId:newExercise:) without changing its sibling, sets, notes or workout metadata.
  • Cover empty workouts, omitted entries, reordering and non-mutation with unit tests, and document the new API.

No app UI changes, movement equivalence checks or load adjustment in this slice. Leave parent #5 open.

Activity

  1. johnnyhuy commented on Nov 15, 2026

    @johnnyhuy
    ContributorAuthor

    agent claim: agent/issue-81-entry-aware-suggestions @ 73dad74

  2. johnnyhuy commented on Nov 15, 2026

    @johnnyhuy
    ContributorAuthor

    Implemented and pushed c23c03b on agent/issue-81-entry-aware-suggestions in #82. All local gates passed, with seven new tests. Linux build and tests, iOS build, security checks and mobile e2e passed; the e2e job had two flaky tests, recorded in #62.

    CI UI coverage passed 26 of 27 tests twice, with different failures in app launch setup and opening the exercise sheet. The failures, unchanged commit and retained result bundles are documented in #83 and the PR body. One final isolated UI job is running before the merge decision. This issue and parent #5 remain open until the slice is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agentclaimed by the BetterFit work loop

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions