Repository navigation
feat: preview saved work before starting a new session - #79
Merged
Merged
Conversation
Co-authored-by: OpenAI Codex <noreply@openai.com>
Co-authored-by: OpenAI Codex <noreply@openai.com>
Co-authored-by: OpenAI Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new-session view now puts the current root's recent saved conversations above the task composer. Each choice opens a read-only preview before continuation, while the composer explains that Send starts a separate session and keeps its own unsent draft.
Part of #4.
Closes #78.
Verification
bun install --frozen-lockfilepassed.bun run lintpassed.bun run typecheckpassed.mise exec -- bun run test:unitpassed, 103 tests across 10 files.mise exec -- bun run test:integrationpassed, 106 tests across 14 files.mise run buildpassed, including all gates and the production bundle.git diff --checkpassed.Proof
Local app launch and screenshot capture are blocked by the incomplete Electron runtime installation. Hosted macOS Playwright verification and capture succeeded on commit
1b736b4. All 66 Electron tests passed.Both screenshots came from the running Electron app at native window dimensions. They were downloaded, visually reviewed, copied to
.tmp/proof/and uploaded directly to this PR. The minimum-size test scrolls to each preview action and then to the task composer and Send button.The artefact contains the choices, saved-conversation preview, minimum-size choices and composer, and an empty root under
Users/runner/work/pidex/pidex/test-results/session-start/. No scratch captures are committed.New component and hook cases
previews the chosen archive and browses history only on explicit actions.replaces choices with the selected root’s history and retains archives recorded under a root alias.has no continuation action for an empty history and disables choices during an open.previews a chosen saved conversation without launching Pi or consuming the new-session draft.New Electron cases cover keyboard preview of the second archive, browsing older work, independent new-task and continuation drafts, aliased archive paths, empty-root switching, native minimum-window scrolling and an intentional fresh-session Send. Previewing must leave the source archive unchanged and issue no session-execution or prompt RPCs. Read-only model discovery can still query Pi. A later Send must use a new archive with only the separate task.
The sidebar's recent-session shortcuts retain their existing immediate-open behaviour. This slice changes the choice in the new-session view. The parent stays open for further recovery work.