Repository navigation
feat: preview saved sessions from navigation shortcuts - #81
Merged
Merged
Conversation
Co-authored-by: OpenAI Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Saved-session shortcuts in the sidebar and Quick switch now open the selected history for preview before an explicit Resume or Fork. Previewing preserves unsent drafts, highlights the selected saved archive and leaves Open sessions as direct actions for their existing live tabs.
Part of #4.
Closes #80.
Verification
bun install --frozen-lockfilepassed.mise exec -- bun run lintpassed.mise exec -- bun run typecheckpassed.mise exec -- bun run test:unitpassed, 103 tests across 10 files.mise exec -- bun run test:integrationpassed, 107 tests across 14 files (final run included in the build).mise run buildpassed, including all gates and the production bundle.git diff --checkpassed.Proof
Local app launch and screenshot capture are blocked by the incomplete Electron runtime installation. Hosted macOS Playwright verification and screenshot capture succeeded on commit
7ca4bf2. All 69 Electron tests passed.The proof artefact includes
sidebar-saved-preview.png,sidebar-saved-preview-narrow.png,quick-switch-saved-preview.pngandopen-session-direct-focus.pngunderUsers/runner/work/pidex/pidex/test-results/session-start/. These are captures of the running Electron app at native window dimensions, including 900 by 600. The screenshots were downloaded to.tmp/proof/and visually reviewed. No scratch captures are committed.Direct inline image upload was unavailable because the browser was in active use. The PNGs are uploaded with this PR's CI artefact and linked above.
New Electron cases cover keyboard sidebar preview, selected-archive highlighting, native minimum-window reachability, keyboard Quick switch selection, unchanged source archives, no session-execution RPCs before continuation, explicit Resume into the selected archive and direct focus of the resulting live tab without another launch or prompt. Screenshots are captured under
.tmp/proof/andtest-results/session-start/; scratch captures are not committed.Component and hook coverage includes
previews a chosen saved conversation without launching Pi or consuming the new-session draftandpreviews saved work for a missing root and reports unreadable archives without starting Pi. Quick switch coverage checks its Preview explanation and archive identity when native IDs are copied.Read-only model discovery may still query Pi. Sending from the history composer resumes the selected path as before. Archive continuation semantics and folder-to-folder context transfer are unchanged. The parent stays open for further recovery work.