Skip to content

[Fix #201]: Add OSGi dependency on SpotBugs - #202

Closed
kgibm wants to merge 1 commit into
eclipse-mat:masterfrom
kgibm:issue201
Closed

kgibm wants to merge 1 commit into
eclipse-mat:masterfrom
kgibm:issue201

Conversation

@kgibm

@kgibm kgibm commented Sep 23, 2026

Copy link
Copy Markdown
Member

No description provided.

Signed-off-by: Kevin Grigorenko <kevin.grigorenko@us.ibm.com>
@kgibm

kgibm commented Sep 23, 2026

Copy link
Copy Markdown
Member Author

@jasonk000 @krumts I'm not an expert in OSGi, so not sure the best way to fix this.

@kgibm

kgibm commented Sep 23, 2026

Copy link
Copy Markdown
Member Author

Adding the com.github.spotbugs.plugin.eclipse dependency in the two MANIFEST.MF files causes a Tycho build error:

[ERROR] Cannot resolve project dependencies:
[ERROR]   Software being installed: org.eclipse.mat.api 1.17.0.qualifier
[ERROR]   Missing requirement: org.eclipse.mat.api 1.17.0.qualifier requires 'java.package; edu.umd.cs.findbugs.annotations 0.0.0' but it could not be found

This is resolved by adding the following to parent/pom.xml:

<repositories>
    <repository>
        <id>spotbugs-eclipse-site</id>
        <layout>p2</layout>
        <url>https://spotbugs.github.io/eclipse/</url>
    </repository>
</repositories>

But that results in Eclipse Dash license vetting failures which I don't know much about:

[INFO] License information could not be automatically verified for the following content:
[INFO] 
[INFO] p2/orbit/p2.eclipse.feature/com.github.spotbugs.plugin.eclipse/4.10.4.r202608200320-1a58a48
[INFO] p2/orbit/p2.eclipse.plugin/com.github.spotbugs.plugin.eclipse/4.10.4.r202608200320-1a58a48
[INFO] 
[INFO] This content is either not correctly mapped by the system, or requires review.
[INFO] Summary file was written to: /Users/kevin/git/mat/parent/target/dash/summary
[ERROR] Dependency license check failed. Some dependencies need to be vetted.

@kgibm

kgibm commented Sep 28, 2026

Copy link
Copy Markdown
Member Author

Close in favor of #205

@kgibm kgibm closed this Sep 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant