Re-add inlined annotations a client removed from the annotation model - #4359
Open
vogella wants to merge 1 commit into
Open
Re-add inlined annotations a client removed from the annotation model#4359vogella wants to merge 1 commit into
vogella wants to merge 1 commit into
Conversation
InlinedAnnotationSupport treated every annotation in fInlinedAnnotations as attached, so once a client removed a code mining annotation from the annotation model directly, the annotation was reused for every later render but never put back into the model and its minings stayed invisible. Annotations the model no longer knows are now added again. Discovered while working on the unified diff of org.eclipse.compare, see eclipse-platform/eclipse.platform#2791 Assisted-by: multiple AI agents and layers of automated tooling 🤖
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
InlinedAnnotationSupport kept every annotation of its last render in
fInlinedAnnotationsand treated all of them as attached. Once a client removed a code mining annotation from the annotation model directly, that annotation object was reused for every later render at the same position but never put back into the model, so the minings there stayed invisible for the rest of the editor session. Annotations the model no longer knows are now added again; the removal side is unchanged.Found while working on the unified diff of
org.eclipse.compare(eclipse-platform/eclipse.platform#2791).