Remove the unused enumerators from CustomHashtable - #4367
Open
vogella wants to merge 1 commit into
Open
Conversation
No caller ever asked the viewer hash table for its keys or its values, so both Enumeration implementations were dead. Without them the firstSlot and lastSlot fields are written but never read, and dropping those takes two branches off every insert and every rehashed entry. Assisted-by: multiple AI agents and layers of automated tooling 🤖
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CustomHashtable, the hash table behind the JFace viewers, still carries twoEnumerationimplementations and itskeys()/elements()accessors. Nothing in the package calls them, and since the class is package-private nothing outside can. Removing them also makesfirstSlotandlastSlotwrite-only, since they existed only to bound the enumerator's scan, so those go too and every insert and every rehashed entry loses two branches.Pure deletion, 101 lines, no behavior change.
toString()stays because the debugger uses it to render the element map. Verified withmvn clean verifyonorg.eclipse.jfaceplusorg.eclipse.jface.tests: 1315 tests, no failures.