Skip to content

fix(devcontainer): repair config volume parent ownership - #200

Open
AlexanderLanin wants to merge 2 commits into
eclipse-score:mainfrom
etas-contrib:fix/config-volume-parent-ownership
Open

AlexanderLanin wants to merge 2 commits into
eclipse-score:mainfrom
etas-contrib:fix/config-volume-parent-ownership

Conversation

@AlexanderLanin

Copy link
Copy Markdown
Member

Tools such as OpenCode need to create state directories below ~/.local. Docker can create the parents of nested configuration volumes as root, leaving the development user unable to create sibling directories such as ~/.local/state.

Ensure the current user owns the .config, .local and .local/share parents. Preserve existing directory permissions and contents, including private mode 0700, while retaining the ownership repair for mounted configuration directories.

Independent extraction from #198, based directly on main. Part of #190.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The ownership test can pass even if .local is omitted from chown, so it must check parent paths specifically in the chown arguments to catch a missing ownership repair.

1 open issue
What changed in this PR

This PR extracts the configuration-volume ownership fix from #198, allowing DevContainer tools to create state directories under ~/.local while preserving existing permissions and contents.

Changes:

  • Repair ownership of .config, .local, and .local/share without changing their modes.
  • Use $HOME for mounted configuration paths instead of /home/vscode.
  • Add regression coverage for parent-directory handling and private permissions.
File Description
tools/​tests/​volume_ownership_test.py Adds checks for parent-directory handling and preservation of mode 0700.
src/​s-core-devcontainer/​.devcontainer/​s-core-local/​fix_config_volume_ownership.sh Repairs parent ownership and retains mounted-directory ownership checks using $HOME.

Review effort: Balanced

Comment thread tools/tests/volume_ownership_test.py Resolved
Copilot AI balanced review requested due to automatic review settings November 4, 2026 13:29
@AlexanderLanin
AlexanderLanin marked this pull request as ready for review November 4, 2026 13:30

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues were identified for the configuration-volume parent ownership changes.

No open issues 🎉

1 resolved since last review

Review effort: Balanced

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants