Repository navigation
Conversation
a-zw
requested review from
AlexanderLanin,
MaximilianSoerenPollak,
dcalavrezo-qorix and
nradakovic
as code owners
November 2, 2026 12:24
Contributor
|
Documentation preview for this pull request is available at: |
There was a problem hiding this comment.
🟡 Changes recommended
Mitigation checks omit platform DFAs and allow lower-ASIL AoU requirements to satisfy mitigation links, leaving documented safety requirements unenforced.
2 open issues
What changed in this PR
This PR promotes safety-analysis mitigation validation from informational reporting to enforcement, addressing issue #970 in the documentation metamodel.
Changes:
- Removes
info_onlyfrom themitigated_bygraph check. - Adds positive, negative, and invalid-status test cases for feature/component safety analyses.
- Marks the requirement implemented and updates the generated-source line-count snapshot.
| File | Description |
|---|---|
src/tests/docs_bzl/scenarios/reference_integration/_expected/docs/modules/modern_module/components/unlinked_component/generated_metamodel/index.html |
Updates the expected metamodel line count. |
src/extensions/score_metamodel/tests/rst/safety/test_saf_mitigated_by.rst |
Adds mitigation-link validation fixtures. |
src/extensions/score_metamodel/metamodel.yaml |
Enables enforcement of the mitigation check. |
docs/internals/requirements/requirements.rst |
Marks implementation complete and removes the transition note. |
Review effort: Balanced
Contributor
Author
|
Created #1014 to fix the check while keeping it info-only. Plan is to release that as a minor change. Afterwards merge this PR for a breaking release. Turning this into a draft for now. |
a-zw
marked this pull request as draft
November 3, 2026 16:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Description
Implement tool_req__docs_saf_attrs_mitigated_by.
Fixes #970
🚨 Impact Analysis
✅ Checklist