Repository navigation
RLIMIT support - part 3 - #868
Open
NicolasFussberger wants to merge 6 commits into
Open
NicolasFussberger wants to merge 6 commits into
NicolasFussberger wants to merge 6 commits into
Conversation
Contributor
|
Documentation preview for this pull request is available at: |
NicolasFussberger
force-pushed
the
rlimit_part3
branch
from
October 27, 2026 12:42
171c58b to
30f35ba
Compare
NicolasFussberger
marked this pull request as ready for review
October 27, 2026 12:43
NicolasFussberger
requested review from
FScholPer,
MaciejKaszynski,
anmittag,
antonkri,
pawelrutkaq and
ramceb
as code owners
October 27, 2026 12:43
MaciejKaszynski
requested changes
Oct 28, 2026
| // Scheduling priority for the component's initial thread. | ||
| scheduling_priority:int32 = null; // required | ||
|
|
||
| // to be removed - only here for compatibility but values will be ignored |
Contributor
There was a problem hiding this comment.
Do you think this removal should be mentioned in a release note? I guess it's not really a breaking changes since it wasn't used but a users build could fail if they did set this.
Contributor
Author
There was a problem hiding this comment.
I guess it would also be good to increase the schema version due to this change?
Contributor
There was a problem hiding this comment.
Yeah think we should maybe start honoring that. Might also be good to keep git tags for the config? so that external tools can reference the raw schema file?
e.g. something like cfg-schema-vX
so then a link like this would never change:
https://raw.githubusercontent.com/eclipse-score/lifecycle/refs/tags/cfg-schema-v1/score/launch_manager/src/daemon/src/configuration/config_schema/launch_manager.schema.json
Contributor
Author
There was a problem hiding this comment.
Could be an idea. I guess at the current stage it might be enough to use the release tag?
I assume we will keep changing the schema for each upcoming release
Contributor
There was a problem hiding this comment.
Yeah that would work too.
NicolasFussberger
force-pushed
the
rlimit_part3
branch
from
October 29, 2026 13:59
30f35ba to
cb9a1b5
Compare
NicolasFussberger
had a problem deploying
to
workflow-approval
October 29, 2026 13:59 — with 
GitHub Actions
Error
GitHub Actions
Error
NicolasFussberger
had a problem deploying
to
workflow-approval
October 29, 2026 13:59 — with
GitHub Actions
Error
GitHub Actions
Error
NicolasFussberger
had a problem deploying
to
workflow-approval
October 29, 2026 13:59 — with
GitHub Actions
Error
GitHub Actions
Error
NicolasFussberger
had a problem deploying
to
workflow-approval
October 29, 2026 13:59 — with
GitHub Actions
Error
GitHub Actions
Error
NicolasFussberger
had a problem deploying
to
workflow-approval
October 29, 2026 14:40 — with
GitHub Actions
Error
GitHub Actions
Error
NicolasFussberger
had a problem deploying
to
workflow-approval
October 29, 2026 14:40 — with
GitHub Actions
Error
GitHub Actions
Error
NicolasFussberger
had a problem deploying
to
workflow-approval
October 29, 2026 14:40 — with
GitHub Actions
Error
GitHub Actions
Error
NicolasFussberger
requested a deployment
to
workflow-approval
October 29, 2026 14:40 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
NicolasFussberger
requested a deployment
to
workflow-approval
October 30, 2026 09:30 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
NicolasFussberger
had a problem deploying
to
workflow-approval
October 30, 2026 09:30 — with
GitHub Actions
Error
GitHub Actions
Error
NicolasFussberger
had a problem deploying
to
workflow-approval
October 30, 2026 09:30 — with
GitHub Actions
Error
GitHub Actions
Error
NicolasFussberger
had a problem deploying
to
workflow-approval
October 30, 2026 09:30 — with
GitHub Actions
Error
GitHub Actions
Error
NicolasFussberger
had a problem deploying
to
workflow-approval
October 30, 2026 12:55 — with
GitHub Actions
Error
GitHub Actions
Error
NicolasFussberger
had a problem deploying
to
workflow-approval
October 30, 2026 12:55 — with
GitHub Actions
Error
GitHub Actions
Error
NicolasFussberger
had a problem deploying
to
workflow-approval
October 30, 2026 12:55 — with
GitHub Actions
Error
GitHub Actions
Error
NicolasFussberger
had a problem deploying
to
workflow-approval
October 30, 2026 12:55 — with
GitHub Actions
Error
GitHub Actions
Error
NicolasFussberger
had a problem deploying
to
workflow-approval
October 30, 2026 14:24 — with
GitHub Actions
Error
GitHub Actions
Error
NicolasFussberger
had a problem deploying
to
workflow-approval
October 30, 2026 14:24 — with
GitHub Actions
Error
GitHub Actions
Error
NicolasFussberger
had a problem deploying
to
workflow-approval
October 30, 2026 14:24 — with
GitHub Actions
Error
GitHub Actions
Error
NicolasFussberger
had a problem deploying
to
workflow-approval
October 30, 2026 14:25 — with
GitHub Actions
Error
GitHub Actions
Error
MaciejKaszynski
previously approved these changes
Oct 30, 2026
NicolasFussberger
force-pushed
the
rlimit_part3
branch
from
October 30, 2026 14:45
76a5ed0 to
85de26b
Compare
NicolasFussberger
had a problem deploying
to
workflow-approval
October 30, 2026 14:45 — with
GitHub Actions
Error
GitHub Actions
Error
NicolasFussberger
had a problem deploying
to
workflow-approval
October 30, 2026 14:45 — with
GitHub Actions
Error
GitHub Actions
Error
NicolasFussberger
had a problem deploying
to
workflow-approval
October 30, 2026 14:45 — with
GitHub Actions
Error
GitHub Actions
Error
NicolasFussberger
had a problem deploying
to
workflow-approval
October 30, 2026 14:45 — with
GitHub Actions
Error
GitHub Actions
Error
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the last PR for adding rlimit support.
It makes the rlimits configurable via json and adds a component/feature-integration test for all rlimits.
See previous PRs:
#847
#845