Repository navigation
Fix uncompleted slot hang during shutdown - #909
Draft
cameron-craig-etas wants to merge 6 commits into
Draft
cameron-craig-etas wants to merge 6 commits into
cameron-craig-etas wants to merge 6 commits into
Conversation
cameron-craig-etas
had a problem deploying
to
workflow-approval
October 30, 2026 15:04 — with
GitHub Actions
Error
cameron-craig-etas
had a problem deploying
to
workflow-approval
October 30, 2026 15:04 — with
GitHub Actions
Error
cameron-craig-etas
had a problem deploying
to
workflow-approval
October 30, 2026 15:04 — with
GitHub Actions
Error
cameron-craig-etas
had a problem deploying
to
workflow-approval
October 30, 2026 15:04 — with
GitHub Actions
Error
cameron-craig-etas
requested a deployment
to
workflow-approval
October 30, 2026 16:51 — with
GitHub Actions
Waiting
cameron-craig-etas
requested a deployment
to
workflow-approval
October 30, 2026 16:51 — with
GitHub Actions
Waiting
cameron-craig-etas
requested a deployment
to
workflow-approval
October 30, 2026 16:51 — with
GitHub Actions
Waiting
cameron-craig-etas
requested a deployment
to
workflow-approval
October 30, 2026 16:51 — with
GitHub Actions
Waiting
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #897
This PR fixes a hang during shutdown when there are unhandled events in the event queue. The unhandled events cause the waiting LmControl thread to block, this in turn prevents launch manager from shutting down.
To reproduce this issue, an integration test was written to fire LmControl requests during shutdown. This test reproduces the issue, causing
launch_managerto hang. A few fixes were needed to get the test passing consistently:The test now passes consistently: