Skip to content

Fix uncompleted slot hang during shutdown - #909

Draft
cameron-craig-etas wants to merge 6 commits into
eclipse-score:mainfrom
etas-contrib:fix/uncompleted-event-hang
Draft

cameron-craig-etas wants to merge 6 commits into
eclipse-score:mainfrom
etas-contrib:fix/uncompleted-event-hang

Conversation

@cameron-craig-etas

@cameron-craig-etas cameron-craig-etas commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Closes #897

This PR fixes a hang during shutdown when there are unhandled events in the event queue. The unhandled events cause the waiting LmControl thread to block, this in turn prevents launch manager from shutting down.

To reproduce this issue, an integration test was written to fire LmControl requests during shutdown. This test reproduces the issue, causing launch_manager to hang. A few fixes were needed to get the test passing consistently:

  • On shutdown, complete any GetActiveRunTarget or SetRequestedRunTarget events.
  • During the event completion loop, a fix was needed to ensure we are using the available timeout, and not exiting prematurely, before the event queue is cleared.

The test now passes consistently:

bazel test --config=host --compilation_mode=dbg --runs_per_test=100 --local_test_jobs=1 //tests/integration/lm_shutdown_with_control_requests

This branch is waiting to be deployed

1 waiting deployment
workflow-approval — fd3143d8 Waiting Oct 30, 2026 by cameron-craig-etas via Build and test arm64-qnx / approval #1988
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

Uncompleted event slots cause hang during shutdown

1 participant