Skip to content

fix(github): remove repository pull request templates - #229

Merged
masc2023 merged 4 commits into
eclipse-score:mainfrom
qorix-group:fix/pr-template-issue-link
Oct 30, 2026
Merged

masc2023 merged 4 commits into
eclipse-score:mainfrom
qorix-group:fix/pr-template-issue-link

Conversation

@janis-qorix

@janis-qorix janis-qorix commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Bugfix

Description

.github/PULL_REQUEST_TEMPLATE/bug_fix.md and improvement.md linked to ../ISSUE_TEMPLATE/new?template=….md, which leads to no issue form in a rendered pull request description (#225).

As requested in review, the pull request templates are now removed instead of repaired. The issue templates they point to are removed in #228 in favour of the issue forms of the organisation (eclipse-score/.github), so the link has no target anymore. If pull request templates are wanted, they can be provided centrally in eclipse-score/.github, which currently has none.

CONTRIBUTION.md referenced the removed templates in step 1 of the contribution steps; the reference is dropped.

The first commit of this PR (changing the link) is superseded by the second one; please squash on merge.

Note: this PR and #228 both touch adjacent lines in CONTRIBUTION.md. Whichever is merged second needs a merge of main first.

Related ticket

closes #225 (bugfix ticket)

🤖 Generated with Claude Code

The pull request templates linked to ../ISSUE_TEMPLATE/new?template=...,
which leads to no issue form in a rendered pull request description.
Link to ../issues/new?template=... instead. Relative to
/<org>/<repo>/pull/<n> this resolves to the repository's new-issue
form, so repositories created from the template need no change.

Fixes eclipse-score#225

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.7.0) and connecting to it...
INFO: Invocation ID: a82068f3-25e8-40e6-a669-5818f3e2dc18
Computing main repo mapping: 
Computing main repo mapping: 
WARNING: For repository 'aspect_rules_lint', the root module requires module version aspect_rules_lint@2.3.0, but got aspect_rules_lint@2.5.0 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
DEBUG: /home/runner/.bazel/external/score_docs_as_code+/docs.bzl:732:14: INFO: ⚠️ DEPRECATED: Passing a Needs inventory through docs(data = [...]) is deprecated!!! Move it to external_needs = [...] instead.
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //:license-check (73 packages loaded, 10 targets configured)

Analyzing: target //:license-check (90 packages loaded, 10 targets configured)

Analyzing: target //:license-check (144 packages loaded, 836 targets configured)

Analyzing: target //:license-check (162 packages loaded, 3941 targets configured)

Analyzing: target //:license-check (163 packages loaded, 9371 targets configured)

Analyzing: target //:license-check (164 packages loaded, 9859 targets configured)

Analyzing: target //:license-check (172 packages loaded, 10004 targets configured)

Analyzing: target //:license-check (176 packages loaded, 12009 targets configured)

Analyzing: target //:license-check (176 packages loaded, 12009 targets configured)

Analyzing: target //:license-check (176 packages loaded, 12009 targets configured)

INFO: Analyzed target //:license-check (177 packages loaded, 13588 targets configured).
[11 / 16] checking cached actions
INFO: From Generating Dash formatted dependency file ...:
INFO: Successfully converted 2 packages from Cargo.lock to bazel-out/k8-fastbuild/bin/formatted.txt
[14 / 16] JavaToolchainCompileBootClasspath external/rules_java+/toolchains/platformclasspath.jar; 0s disk-cache, processwrapper-sandbox
[15 / 16] Building license.check.license_check.jar (); 0s disk-cache, multiplex-worker
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 181.351s, Critical Path: 2.30s
INFO: 16 processes: 12 internal, 3 processwrapper-sandbox, 1 worker.
INFO: Build completed successfully, 16 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

@janis-qorix
janis-qorix marked this pull request as ready for review October 29, 2026 17:57
@github-actions

Copy link
Copy Markdown
Contributor

Documentation preview for this pull request is available at:
pr-229: https://eclipse-score.github.io/module_template/pr-229/

@masc2023 masc2023 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Propose also to move them to .github, as they are distributed automatically, if required

RolandJentschETAS and others added 2 commits October 30, 2026 07:04
The pull request templates linked to a non-existent issue form, and the
issue templates they refer to are being removed in favour of the
organisation's issue forms. Remove the pull request templates as well,
as requested in review, and drop the reference from CONTRIBUTION.md.

Fixes eclipse-score#225

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@janis-qorix janis-qorix changed the title fix(github): link pull request templates to the issue form fix(github): remove repository pull request templates Oct 30, 2026
@janis-qorix
janis-qorix requested a review from masc2023 October 30, 2026 08:25
@masc2023
masc2023 merged commit 23642c3 into eclipse-score:main Oct 30, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

Pull request templates link to a non-existent issue form

3 participants