Repository navigation
Align Security work products with ISO SAE 21434 and fix template inconsistencies - #236
Merged
PandaeDo merged 8 commits intoNov 4, 2026
Merged
Conversation
janis-qorix
requested review from
PandaeDo,
RolandJentschETAS,
aschemmel-tech,
masc2023 and
pahmann
as code owners
November 3, 2026 17:08
2 tasks done
Contributor
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //:license-checkStatus: Click to expand output |
Contributor
|
Documentation preview for this pull request is available at: |
masc2023
requested changes
Nov 4, 2026
RolandJentschETAS
previously approved these changes
Nov 4, 2026
Add empty line after captions, replace line blocks by plain paragraphs and align underline lengths in the new security manual sections. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
masc2023
approved these changes
Nov 4, 2026
PandaeDo
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improves the quality and ISO SAE 21434 alignment of the module template's Security work products, which had largely been copy-pasted from the Safety equivalents without adapting to where the two standards actually differ.
module_security_package_fdr.rst,module_security_plan_fdr.rst): added aReferencecolumn linking each checklist item to the relevantstd_req__isosae21434__*/std_wp__isosae21434__*needs already published inprocess_description, and aConductsection (mirroring the Safety FDRs). Split the previously conflated "Process Security Audit" check into the two concepts ISO SAE 21434 actually separates: the organizational Cybersecurity Audit (clause 5.4.7) and the project-level Cybersecurity Assessment (clause 6.4.8). Added checklist items with no Safety equivalent (OTS/OSS qualification, post-development vulnerability/verification info).module_security_plan.rst): fixed an indentation bug where sections 1–5 (Context, Scope, Roles, Tailoring, Work Products) were unintentionally nested inside the.. attention::admonition and rendered as part of the warning box. Converted to proper RST sections and alist-tablefor roles, matching the Safety Plan's structure. Added four new ISO SAE 21434–specific sections with no Safety equivalent: Component Out-of-Context Assumptions, Off-the-Shelf/OSS Component Qualification, Cybersecurity Assessment Decision, and Vulnerability Monitoring and Management. Filled in the previously empty "Link to process"/"Link to WP" columns in both work product tables with the existing, verified guidance/template needs.security_manual.rst): fixed AoUneedtablefilters to also checksecurity == "YES"(previously listed all AoUs regardless of relevance), added the missing "mitigates a security analysis entry" attention box and platform/module scoping note (present in the Safety Manual but missing here), replaced a copy-pasted Safety example (HW/QM error wording) with a security-relevant one, and added new sections: Cybersecurity Claims and Residual Risk, Secure Configuration and Hardening, Vulnerability Reporting, and Security Support.:security: YES→NOonmodule_safety_analysis_fdr.rst; fixed a document ID mismatch and typo insecurity_planning/index.rst; de-duplicated a template AoU example ID shared between the Safety and Security component templates; added the missingsafety != "QM"filter to the Safety Manual's AoU tables; fixed a"feature_example"/"feature_name"filter inconsistency insafety_planning/index.rst.All added
:need:references reuse existing, already-published IDs fromprocess_description(or existing module template documents) — no ISO/SAE 21434 standard text is reproduced, per the project's licensing constraints on that standard.Test plan
bazel build //:docscompletes successfully with no broken:need:referencespre-commit runon all changed files passes (copyright headers, REUSE lint, whitespace, bazel mod tidy)