Skip to content

Stopped the version pass skipping ports in silence #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fdesbiens merged 1 commit into from
Sep 29, 2026
Merged

Stopped the version pass skipping ports in silence #113

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 29 additions & 2 deletions scripts/prepare_release.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,15 +145,42 @@ PORT_FILES=$(printf "%s" "${PORT_FILES}" | grep -v '^[[:space:]]*$' || true)
if [ -z "${PORT_FILES}" ]; then
printf "Warning: No port header files found. Skipping port version string commit.\n"
else
# A port advertises its release in the string the library reports at run time.
# The pattern accepts three or four dotted numbers and tolerates a stray
# letter before the first one, so a port that writes its version slightly
# differently is still reached.
VERSION_RE='Version[[:space:]]+[A-Za-z]?[0-9]+(\.[0-9]+)+[a-z]*'
while IFS= read -r port_file; do
if [ -n "${port_file}" ] && grep -qE "Version [0-9]" "${port_file}" 2>/dev/null; then
sed -i -E "s/Version [0-9]+\.[0-9]+\.[0-9]+\.[0-9]+[a-z]*/Version ${VERSION}/g" "${port_file}"
if [ -n "${port_file}" ] && grep -qE "${VERSION_RE}" "${port_file}" 2>/dev/null; then
sed -i -E "s/${VERSION_RE}/Version ${VERSION}/g" "${port_file}"
printf " Updated: %s\n" "${port_file#${REPO_ROOT}/}"
fi
done <<EOF
${PORT_FILES}
EOF

# Every port header that names a release must now name this one. A port
# whose string is shaped in some other way is not rewritten above, and
# without this check the pass reports success while leaving that port
# advertising the previous release for the life of the version.
STALE=""
while IFS= read -r port_file; do
[ -n "${port_file}" ] || continue
advertised=$(grep -hoE '"[^"]*[0-9]+\.[0-9]+\.[0-9]+[^"]*"' "${port_file}" 2>/dev/null || true)
[ -n "${advertised}" ] || continue
if ! printf "%s" "${advertised}" | grep -qF "${VERSION}"; then
STALE="${STALE} ${port_file#${REPO_ROOT}/}
"
fi
done <<EOF
${PORT_FILES}
EOF
if [ -n "${STALE}" ]; then
printf "\nError: these port headers still advertise another release:\n%s" "${STALE}" >&2
printf "Correct them so the substitution above reaches them, then re-run.\n" >&2
exit 1
fi

git -C "${REPO_ROOT}" add -u
if git -C "${REPO_ROOT}" diff --cached --quiet; then
printf "No port version string changes staged. Skipping commit.\n"
Expand Down