Repository navigation
Conversation
Fixes eclipse-threadx#97 When a writer allocates a zero-length file's first cluster, FileX updates other open handles but leaves their first cluster at zero. A later seek uses that stale value and reads the wrong sector. Copy the first cluster when initializing other handles opened before the allocation. Add a RAM-disk regression for ordinary and fast readers, and make CTest recognize failures reported by its standalone test harness. GCC 14 CMake/Ninja: the regression failed on dev and passed in four build configurations with the fix. Three existing read/write and seek regressions passed. The new assignment was exercised. No hardware test. Assisted-by: Codex (GPT-6-Sol) <noreply@openai.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #97
When a writer allocates a zero-length file's first cluster, FileX updates other open handles but leaves their first cluster at zero. A later seek uses that stale value and reads the wrong sector.
Copy the first cluster when initializing other handles opened before the allocation. A RAM-disk regression checks ordinary and fast readers after seeking, and CTest now recognizes failures reported by its standalone test harness. @rahmanih, please review this PR; I am happy to change the approach if you disagree.
GCC 14 CMake/Ninja: the regression failed on dev and passed in ThreadX, standalone, no-cache, and fault-tolerant builds with the fix. Three existing read/write and seek regressions passed. The new assignment was exercised. No hardware test.