Stopped the version pass skipping ports in silence - #786
Merged
Merged
Conversation
The port stage matched a version only where "Version" was followed immediately by four dotted numbers. A port writing three numbers, or a stray letter before the first, was passed over and kept its old release, and the pass reported success either way. The RISC-V32/IAR port is one of them. It reads "Version G6.5.0.202601", and the letter in front of the number has kept it out of every pass since, so it has advertised 6.5.0.202601 across two releases it was not part of. Its string now reads the current release. The pattern accepts three or four numbers and tolerates a leading letter. A check follows it: any port header that names a release other than the one being prepared is listed and the pass stops, so a port the substitution cannot reach fails the release instead of shipping a version that misreports itself. Verified: every ThreadX port header now advertises 6.5.2.202603. Against a FileX tree, a port the substitution cannot reach makes the pass name the file and exit non-zero, and correcting that string lets the pass complete. Assisted-by: Claude Code (Opus 5) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The port stage of
prepare_release.shmatched a version only whereVersionwas followed immediately by four dotted numbers. A port writing three numbers, or carrying a stray letter before the first, was passed over and kept its old release — and the pass printed its usual success either way.ThreadX has one such port.
ports/risc-v32/iar/inc/tx_port.hreadsVersion G6.5.0.202601, and the letter in front of the number has kept it out of every pass since it appeared, so it has advertised 6.5.0.202601 across two releases it was not part of. The version pass for 6.5.2.202603 has already run and did not touch it. Its string now reads the current release.The pattern now accepts three or four numbers and tolerates a leading letter. More to the point, a check follows it: any port header that names a release other than the one being prepared is listed by path and the pass stops. A port the substitution cannot reach now fails the release rather than shipping a version that misreports itself.
The same gap exists across the suite and is fixed in filex#113, netxduo#458, guix#200 and usbx#288. FileX's Win32 and Win64 ports were about to ship reporting the previous release; NetX Duo's Cortex-R5/GNU port reads
Version 6.4.1.Verified: every ThreadX port header now advertises 6.5.2.202603. Against a FileX tree, a port the substitution cannot reach makes the pass name the file and exit non-zero, and correcting that string lets the pass complete.