Skip to content

feat!: remove compression_model input field #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KokaKiwi merged 2 commits into from
Oct 2, 2026
Merged

feat!: remove compression_model input field #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5945ba0
feat!: remove compression_model input field
KokaKiwi Sep 30, 2026
0eebded
Merge branch 'main' into edgee-1640-rework-per-request-compression-he…
KokaKiwi Oct 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions edgee/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
import json
import os
import ssl
import warnings
from dataclasses import dataclass
from urllib.error import HTTPError
from urllib.parse import urlparse
Expand Down Expand Up @@ -77,8 +76,6 @@ class InputObject:
tools: list[dict] | None = None
tool_choice: str | dict | None = None
tags: list[str] | None = None
# Deprecated: any value turns tool-result trimming on. Use tool_result_trimming instead.
compression_model: str | None = None
# Per-request overrides of the API key settings. None keeps the key setting.
tool_result_trimming: bool | None = None
tool_surface_reduction: bool | None = None
Expand Down Expand Up @@ -239,21 +236,18 @@ def send(
tools = None
tool_choice = None
tags = None
compression_model = None
toggles = {}
elif isinstance(input, InputObject):
messages = input.messages
tools = input.tools
tool_choice = input.tool_choice
tags = input.tags
compression_model = input.compression_model
toggles = {field: getattr(input, field) for field in COMPRESSION_HEADERS}
else:
messages = input.get("messages", [])
tools = input.get("tools")
tool_choice = input.get("tool_choice")
tags = input.get("tags")
compression_model = input.get("compression_model")
toggles = {field: input.get(field) for field in COMPRESSION_HEADERS}

body: dict = {"model": model, "messages": messages}
Expand All @@ -265,13 +259,6 @@ def send(
body["tool_choice"] = tool_choice
if tags:
body["tags"] = tags
if compression_model is not None:
warnings.warn(
"compression_model is deprecated; use tool_result_trimming=True instead",
DeprecationWarning,
stacklevel=2,
)
body["compression_model"] = compression_model

request = Request(
f"{self.base_url}{API_ENDPOINT}",
Expand Down
15 changes: 0 additions & 15 deletions tests/test_edgee.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,18 +460,3 @@ def test_streaming_request_sends_toggles(self, mock_urlopen):
request, _ = self._sent(mock_urlopen)
assert request.get_header(self.SURFACE.capitalize()) == "true"
assert not request.has_header(self.TRIM.capitalize())

@patch("edgee.urlopen")
def test_compression_model_is_deprecated_but_still_sent(self, mock_urlopen):
mock_urlopen.return_value = self._ok()
with pytest.warns(DeprecationWarning, match="tool_result_trimming"):
Edgee("test-api-key").send(
model="gpt-4",
input={
"messages": [{"role": "user", "content": "Hello"}],
"compression_model": "claude",
},
)

_, body = self._sent(mock_urlopen)
assert body["compression_model"] == "claude"
Loading