Skip to content

Keep Nix compiler launchers on patched Node - #926

Merged
jfet97 merged 2 commits into
mainfrom
fix/patched-node-toolchain
Oct 22, 2026
Merged

jfet97 merged 2 commits into
mainfrom
fix/patched-node-toolchain

Conversation

@jfet97

@jfet97 jfet97 commented Oct 22, 2026 •

Copy link
Copy Markdown
Collaborator

Why

The shell already selects patched Node, but Nix-generated TypeScript launchers still bind to the older runtime from Nixpkgs.

What

Build those compiler launchers with the same Node 24.22.1 used by the shell. Make the inactive-query lifecycle test await completed suspense setup.

How

Override TypeScript's npm builder and expose the Node metadata it requires. Replace the test helper's 40 ms race with awaiting the actual setup promise, so pending setup cannot be treated as completed.

Remarks

The existing Node/pnpm archives, dependency resolutions and library behavior remain unchanged.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@jfet97
jfet97 marked this pull request as ready for review October 22, 2026 11:34
@pkg-pr-new

pkg-pr-new Bot commented Oct 22, 2026

Copy link
Copy Markdown

Open in StackBlitz

@effect-app/cli

npm i https://pkg.pr.new/@effect-app/cli@926

effect-app

npm i https://pkg.pr.new/effect-app@926

@effect-app/eslint-codegen-model

npm i https://pkg.pr.new/@effect-app/eslint-codegen-model@926

@effect-app/eslint-shared-config

npm i https://pkg.pr.new/@effect-app/eslint-shared-config@926

@effect-app/infra

npm i https://pkg.pr.new/@effect-app/infra@926

@effect-app/vue

npm i https://pkg.pr.new/@effect-app/vue@926

@effect-app/vue-components

npm i https://pkg.pr.new/@effect-app/vue-components@926

commit: 0da96bf

@jfet97
jfet97 merged commit 173e8da into main Oct 22, 2026
5 checks passed
@jfet97
jfet97 deleted the fix/patched-node-toolchain branch October 22, 2026 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant