Repository navigation
Keep Nix compiler launchers on patched Node - #926
Merged
Merged
Conversation
jfet97
marked this pull request as ready for review
October 22, 2026 11:34
@effect-app/cli
effect-app
@effect-app/eslint-codegen-model
@effect-app/eslint-shared-config
@effect-app/infra
@effect-app/vue
@effect-app/vue-components
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The shell already selects patched Node, but Nix-generated TypeScript launchers still bind to the older runtime from Nixpkgs.
What
Build those compiler launchers with the same Node 24.22.1 used by the shell. Make the inactive-query lifecycle test await completed suspense setup.
How
Override TypeScript's npm builder and expose the Node metadata it requires. Replace the test helper's 40 ms race with awaiting the actual setup promise, so pending setup cannot be treated as completed.
Remarks
The existing Node/pnpm archives, dependency resolutions and library behavior remain unchanged.
Need help on this PR? Tag
@codesmith-botwith what you need.