Skip to content

ci: shorten pull request test runs - #6056

Merged
fengmk2 merged 4 commits into
nextfrom
codex/ci-performance
Sep 24, 2026
Merged

fengmk2 merged 4 commits into
nextfrom
codex/ci-performance

Conversation

@fengmk2

@fengmk2 fengmk2 commented Sep 24, 2026 •

Copy link
Copy Markdown
Member

Each pull request runs the full test suite on nine platform and Node.js combinations. Repeated test work and runner waits delay feedback.

Run Node.js 22, 24, and 26 on Linux. Run Node.js 24 on macOS and Windows. Split the four slower combinations into two test groups. Keep all nine combinations for merge groups, next pushes, manual runs, and PR runs with the ci:full label.

The following table compares the measured GitHub Actions runs for ordinary PR feedback.

Metric Before After Reduction
CI elapsed time 20m 49s 13m 10s 36.7%
Total runner execution time 151.68 minutes 86.78 minutes 42.8%

Elapsed time includes queue delays. Runner minutes exclude queue delays and the separate E2E workflow. The baseline had a CLI failure; all main-suite jobs passed. This is a single-run comparison, so queue delays and cache state can affect later results.

Use one exact Node.js version for coverage. Check that coverage groups contain every test file exactly once before merging their reports. Save durations, retries, and resolved worker settings as artifacts. Make done reject failed, cancelled, missing, or unexpectedly skipped checks.

Replace fixed schedule readiness waits with checks for the expected condition. Use available inspector ports and distinguish --inspect-port from --inspect in the CLI.

Update codecov/codecov-action to v5.5.5 so uploads use the current signing-key endpoint.

Summary by CodeRabbit

  • Bug Fixes

    • Node.js inspector options are now recognized correctly when similar options are already configured, improving debug and development command behavior.
  • CI

    • Pull request checks now use a tailored test matrix, with shard results validated before coverage reports are merged.
    • CI checks also run for reopened pull requests and merge queue events.
  • Documentation

    • Updated CI workflow and performance documentation to reflect the current test matrix, coverage reporting, and parallel test metrics.

@coderabbitai

coderabbitai Bot commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 86b0c6ef-5cae-4de5-8dfd-31c132197f2c

📥 Commits

Reviewing files that changed from the base of the PR and between c923334 and ad50bde.

📒 Files selected for processing (21)
  • .github/workflows/ci.yml
  • plugins/schedule/test/customTypeError.test.ts
  • plugins/schedule/test/immediate.test.ts
  • plugins/schedule/test/scheduleError.test.ts
  • plugins/schedule/test/subscription.test.ts
  • scripts/ci-coverage.js
  • scripts/ci-plan.js
  • scripts/ci-reporter.ts
  • scripts/ci-test-benchmark/environment.js
  • scripts/test/ci.test.js
  • tools/egg-bin/src/baseCommand.ts
  • tools/egg-bin/test/commands/debug.test.ts
  • tools/egg-bin/test/commands/dev.test.ts
  • vitest.config.ts
  • wiki/concepts/vitest-isolate-false-state-leaks.md
  • wiki/index.md
  • wiki/log.md
  • wiki/sources/ci-performance-baseline.md
  • wiki/workflows/ci-parallel-test-metrics.md
  • wiki/workflows/ci-performance-plan.md
  • wiki/workflows/local-ci.md
 _____________________________________________________________________
< You added a feature flag. Great-now we can ship bugs *selectively*. >
 ---------------------------------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Deploying egg with  Cloudflare Pages  Cloudflare Pages

Latest commit: ad50bde
Status: ✅  Deploy successful!
Preview URL: https://3c48805f.egg-cci.pages.dev
Branch Preview URL: https://codex-ci-performance.egg-cci.pages.dev

View logs

@codecov

codecov Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.30%. Comparing base (c923334) to head (ad50bde).

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #6056      +/-   ##
==========================================
+ Coverage   82.98%   83.30%   +0.31%     
==========================================
  Files         732      732              
  Lines       22522    22523       +1     
  Branches     4536     4536              
==========================================
+ Hits        18691    18763      +72     
+ Misses       3318     3257      -61     
+ Partials      513      503      -10     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Deploying egg-v3 with  Cloudflare Pages  Cloudflare Pages

Latest commit: ad50bde
Status: ✅  Deploy successful!
Preview URL: https://7974d138.egg-v3.pages.dev
Branch Preview URL: https://codex-ci-performance.egg-v3.pages.dev

View logs

@fengmk2
fengmk2 marked this pull request as ready for review September 24, 2026 07:36
Copilot AI lite review requested due to automatic review settings September 24, 2026 07:36

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@fengmk2
fengmk2 merged commit a11a6d5 into next Sep 24, 2026
59 of 60 checks passed
@fengmk2
fengmk2 deleted the codex/ci-performance branch September 24, 2026 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants