Skip to content

fix: scope CodeQL to maintained source - #5

Merged
ekkolon merged 5 commits into
mainfrom
fix/codeql-findings
Oct 8, 2026
Merged

ekkolon merged 5 commits into
mainfrom
fix/codeql-findings

Conversation

@ekkolon

@ekkolon ekkolon commented Oct 8, 2026 •

Copy link
Copy Markdown
Owner

Both open alerts originate in generated third-party code: undici uses protocol-mandated SHA-1 for WebSocket handshakes (RFC 6455), and is-unsafe matches the XML --> comment terminator. Neither rule identifies a flaw in setup-zig's own signature verification.

Scan src/, scripts/, and test/ with the pinned CodeQL workflow; leave dist/ to reproducible-build checks, dependency audits, and the SBOM. Add a regression check for the scan scope.

Before enabling SARIF uploads, switch off GitHub's CodeQL default setup in Settings → Advanced Security; it currently rejects results from this advanced workflow. No suppression of first-party findings.

@ekkolon ekkolon changed the title Fix CodeQL security findings Scope CodeQL to maintained source Oct 8, 2026
@github-advanced-security

Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

@ekkolon ekkolon changed the title Scope CodeQL to maintained source fix: scope CodeQL to maintained source Oct 8, 2026
@ekkolon
ekkolon merged commit 1debbfa into main Oct 8, 2026
10 of 11 checks passed
@ekkolon
ekkolon deleted the fix/codeql-findings branch October 8, 2026 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants