fix(commerce-elastic-path): load complete account roster - #660
Merged
Merged
Conversation
field123
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #609.
Unpaged account roster reads now return the complete organisation roster instead of only the first 100 accounts.
The server-side roster endpoint walks Elastic Path account-token pages sequentially at the platform page size of 100 and returns the existing:
shape once all pages have been collected.
Explicit paged requests using
{ limit, offset }remain single-page operations.If a later page fails, the whole roster request uses the existing account-token failure path rather than returning a partial roster. For a large roster, this means a later-page failure now results in the Provider's existing empty-roster fallback instead of the first page alone. This is intentional: a partial list beside a larger
totalshouldn't be treated as a complete roster.No changes were made to the Account Provider, identity client, login flow, selection/retry behavior, or Studio surface.
Testing
tsc --noEmit: clean