Repository navigation
fix: ship MSIX logo assets so the Windows app icon isn't a placeholder - #2066
Open
claude[bot] wants to merge 1 commit into
Open
claude[bot] wants to merge 1 commit into
claude[bot] wants to merge 1 commit into
Conversation
MakerMSIX had no packageAssets, so electron-windows-msix copied its bundled Visual Studio placeholder logos into the package and Windows showed the box-with-an-X icon in the Start menu and taskbar. Add Fiddle's logo, rendered from fiddle.svg, under every name the generated AppxManifest references (icon, Square44x44Logo, Square150x150Logo) with scale-100 to scale-400 variants, plus the Square44x44Logo targetsize-16/24/32/48/256 plated and unplated variants the taskbar uses. Also set logLevel to 'warn' so the library's warnings show up in make output. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PiGRtCfigd5Ue2xwVm4n3y
erickzhao
marked this pull request as ready for review
November 3, 2026 17:49
erickzhao
approved these changes
Nov 3, 2026
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Erick Zhao · Slack thread
In the 1.0.0-alpha MSIX build, the app icon shows up as the box-with-an-X placeholder. That happens because the MakerMSIX config never set
packageAssets, so electron-windows-msix fell back to the placeholder PNGs it bundles from the Visual Studio template. This PR renders Fiddle's logo fromfiddle.svgintopackages/app/assets/msix/under every name the generated AppxManifest references (icon,Square44x44LogoandSquare150x150Logo), with scale-100 to scale-400 variants and the targetsize-16/24/32/48/256 plated and unplatedSquare44x44Logovariants the taskbar picks from. The images are transparent and padded like Windows app icons. The PR also pointspackageAssetsat that folder and setslogLevel: 'warn'so the library's warnings appear inmakeoutput. I ran the library's manifest and layout generation on Linux and every referenced file is in the layout, but I haven't checked the result on a real Windows taskbar or Start menu yet.Generated by Claude Code