Repository navigation
build(deps-dev): bump @electron-forge/shared-types from 8.0.0-alpha.10 to 8.0.1 - #2069
dependabot[bot] wants to merge 1 commit into
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
| "@electron-forge/plugin-vite": "8.0.0-alpha.10", | ||
| "@electron-forge/publisher-github": "8.0.0-alpha.10", | ||
| "@electron-forge/shared-types": "8.0.0-alpha.10", | ||
| "@electron-forge/shared-types": "8.0.1", |
There was a problem hiding this comment.
🔴 CI and release jobs that run yarn install --immutable will probably fail after this merge, because the lockfile no longer agrees with the root resolution. The root resolutions in package.json:34 still pins @ electron-forge/shared-types to 8.0.0-alpha.10. Yarn rewrites every shared-types descriptor to that version, but the new yarn.lock has only an @ npm:8.0.1 entry. Even a non-immutable install would put alpha.10 back, so the bump changes nothing. Fix: make the root resolution and the app pin agree, then regenerate yarn.lock with flock /tmp/fiddle-2027-yarn.lock yarn install. Either bump the resolution to 8.0.1 together with the bump, or close this PR.
Why this was flagged
The root package.json:33-34 resolutions forces @ electron-forge/shared-types to 8.0.0-alpha.10 (alongside @ electron-forge/maker-base). On the base branch the lockfile honours this. yarn.lock:567 holds @ electron-forge/shared-types@ npm:8.0.0-alpha.10, and maker-base also stays at alpha.10 even though maker-squirrel asks for npm:8.0.1. This diff replaces that entry with @ electron-forge/shared-types@ npm:8.0.1 and adds @ electron-forge/tracer@ npm:8.0.1 and the listr2 11 tree. It leaves the resolution unchanged, so most Forge packages still reference npm:8.0.0-alpha.10 (yarn.lock:359, 377, 409 and others) with no lockfile entry to resolve to. .github/workflows/ci.yml:56 and :138, and release.yml:57, :127 and :220, run yarn install --immutable. Yarn re-resolves through the resolution to alpha.10, needs to change the lockfile, and so fails the install, which the base branch does not. Running a plain install instead puts the alpha.10 entry back, so the 8.0.1 bump never takes effect.
Verification: normal. This happens on every CI or release run of yarn install --immutable after the merge. Root package.json:34 is untouched by the diff and still pins @ electron-forge/shared-types to 8.0.0-alpha.10, but the diff replaces yarn.lock line 567 with "@ electron-forge/shared-types@ npm:8.0.1", so there is no longer any shared-types alpha.10 key. So an immutable install sees that the lockfile would change and fails.
Bumps [@electron-forge/shared-types](https://github.com/electron/forge) from 8.0.0-alpha.10 to 8.0.1. - [Release notes](https://github.com/electron/forge/releases) - [Changelog](https://github.com/electron/forge/blob/main/CHANGELOG.md) - [Commits](electron/forge@v8.0.0-alpha.10...v8.0.1) --- updated-dependencies: - dependency-name: "@electron-forge/shared-types" dependency-version: 8.0.1 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
dc45042 to
cde1229
Compare
Bumps @electron-forge/shared-types from 8.0.0-alpha.10 to 8.0.1.
Release notes
Sourced from @electron-forge/shared-types's releases.
... (truncated)
Changelog
Sourced from @electron-forge/shared-types's changelog.
... (truncated)
Commits
48f38bbchore: bump version to 8.0.1 (#4426)40b4adfchore: bump version to 8.0.0 (#4425)2868de8refactor(maker-appx)!: reimplement as a legacy wrapper over the MSIX maker (#...d7c592cdocs: add AGENTS.md guidance for AI coding agents (#4416)5023ae1build(deps): upgrade Electron to 44.4.3 (#4410)1d268aabuild(deps): bump vulnerable transitive and direct dependencies (#4408)c7bae14fix(template): typecheck root-level config files (#4407)198d934fix(template-vite): use .mts for Vite configs in the TypeScript variant (#4406)e0fb4d4build: bump@electron/lint-rollerto ^4.0.0 (#4404)7b2f0e8feat!: replacerelease --from-dry-runwith--from-make, and `make --skip-...