Repository navigation
build(deps-dev): bump electron from 44.4.3 to 44.10.0 - #4456
Conversation
Bumps [electron](https://github.com/electron/electron) from 44.4.3 to 44.9.1. - [Release notes](https://github.com/electron/electron/releases) - [Commits](electron/electron@v44.4.3...v44.9.1) --- updated-dependencies: - dependency-name: electron dependency-version: 44.9.1 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
| version: 44.10.0 | ||
| resolution: "electron@npm:44.10.0" | ||
| dependencies: | ||
| "@electron-internal/extract-zip": "npm:^1.0.1" | ||
| "@electron/get": "npm:^5.0.0" | ||
| "@types/node": "npm:^24.9.0" | ||
| bin: | ||
| electron: cli.js | ||
| install-electron: install.js | ||
| checksum: 10c0/6c26e1d9c4351ebee7a4e3ceff189a7112f408600ff21f37ac345e42fe643b366f60d44fce0b4ebf4c5bdd9b1923e98298340b1263036c9e29565bf9e713b6c9 | ||
| checksum: 10c0/32fcc950d31206c9db555dfb80b34478cbf01505ddd22f899caf960ed3618b03fbd114c1f61d9837b1067f33e4760fc0de37ec9e6a8e363a250eb8c2ba9d78ba |
There was a problem hiding this comment.
🟡 (optional) Merging would install Electron 44.10.0, not the 44.9.1 this PR says it bumps to and whose release notes reviewers read. The electron@ npm:^44.4.3 entry resolves to electron@ npm:44.10.0, with a new 10c0 checksum. No release notes cover that version, and nothing ties the checksum to it. Fix: make the lockfile and the PR agree before merging. Either let Dependabot regenerate the lockfile so it pins 44.9.1, or retitle the PR to 44.10.0 and check that version's notes and its checksum against the registry tarball.
Why this was flagged
yarn.lock:7634-7635 sets version: 44.10.0 and resolution: "electron@ npm:44.10.0". yarn.lock:7643 swaps in a new checksum. The PR title, the description and the compare link (v44.4.3...v44.9.1) all name 44.9.1 as the target, and the notes stop at v44.9.1. A yarn install --immutable after merge would fetch and run electron 44.10.0, including its install.js postinstall that downloads the Electron binary. Its changes and its integrity hash were never in the reviewed material. On the base branch, 44.4.3 is pinned with the old checksum. This kind of mismatch can come from a Dependabot rebase that was never retitled, or from a hand-edited lockfile. Neither can be ruled out from this checkout, and the 10c0 checksum only guards against cache corruption, not against an unreviewed version. package.json:55 keeps ^44.4.3, so the range does not stop either version.
Verification: Trigger: any yarn install after merge uses the lockfile. In the "electron@ npm:^44.4.3" entry the diff sets version: 44.10.0 and resolution: "electron@ npm:44.10.0" (yarn.lock:7634-7635) and swaps the checksum at yarn.lock:7643. The only commit in the range, b2438aa, is titled "build(deps-dev): bump electron from 44.4.3 to 44.9.1". If 44.10.0 is not published, installs fail.
Bumps electron from 44.4.3 to 44.9.1.
Release notes
Sourced from electron's releases.
... (truncated)
Commits
e02265bfix: apply the certificate SPKI blocklist to Node and add entries (44-x-y) (#...0545d89test: replace fix_crypto_tests_to_run_with_bssl.patch with upstream backport ...0ec830fdocs: fix code block line highlighting after docs reformats (#55102)68ddc64test: re-enable Node.js tests that now pass with BoringSSL (#55095)cb2bde2build: stop overriding node GN declare_args defaults in patch (#55077)aa16ac2build: update PGO profiles (#55090)fd148b9feat: add app shims on macOS (#55073)fe5dd7efix: avoid misaligned char16_t reads in crdtp string deserialization (#55061)c6874c5fix: use the opener's session and webPreferences for windows opened from link...790b4b8ci: skip native builds when installing deps for type generation (#55066)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.