Repository navigation
fix: onboard connect no longer keeps the agent's command open on Windows (1.6.1) - #164
Merged
Merged
Conversation
bitpshr
changed the title
bitpshr
marked this pull request as ready for review
October 17, 2026 01:59
PaulAsjes
approved these changes
Oct 17, 2026
kraenhansen
added a commit
that referenced
this pull request
Oct 20, 2026
* [fern-generated] Update SDK Generated by Fern CLI Version: unknown Generators: - fernapi/fern-cli-generator: 0.38.4 * [fern-replay] Applied customizations Patches applied (5): - patch-3324bcc8: build: publish prereleases to homebrew and scoop - patch-3acf25c9: feat: Adds new say command (#143) - patch-3866acd2: Make intent optional (#150) - patch-0d14627a: fix: don't send Authorization alongside an explicit API key (#153) - patch-ab3cae7d: fix: onboard check finds the key file by name in a monorepo package (1.5.2) (#160) Patches with unresolved conflicts (7): - patch-809b383f: fix(deps): patch two advisories; keep the verification script - patch-590ac6e0: Alpha build - patch-composite-7dd8e976: Customer customizations (composite) - patch-147b7f4d: feat: tag CLI requests with the command that made them (#132) - patch-2fb0d577: feat: Make intent mandatory for agents (#148) - patch-68caee9a: feat: add onboard init, connect, check and test for agent-led setup (#154) - patch-d0001ac9: fix: onboard flags that survive npx, and check that the app loads the key (1.5.1) (#159) Run `fern-replay resolve` to apply these customizations. Patches absorbed by generator (3): - patch-60647625: fix: onboard replies survive grep, and the agent keeps the link whole and lists what's left (1.5.3) (#162) - patch-7c12df85: fix: onboard lets the agent make the API calls a request needs, like creating an agent (1.6.0) (#163) - patch-3cf27685: fix: onboard connect no longer keeps the agent's command open on Windows (1.6.1) (#164) The generator now produces these customizations natively. * fix(deps): restore patched Cargo.lock and prerelease-safe dist config Fern replay reverted both to generator defaults: rustls 0.23.41 (RUSTSEC-2026-0285), the rand 0.10 family, and publish-prereleases = true. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix: adapt to the regenerated SDK's agents.delete signature The spec added an optional `force` query to DELETE /v1/convai/agents/{agent_id}, so the generated method now takes an AgentsDeleteQueryRequest. Also refresh flows_spec.json for the new `environments` group. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: fern-api[bot] <115122769+fern-api[bot]@users.noreply.github.com> Co-authored-by: Kræn Hansen <kraen@elevenlabs.io> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On Windows,
onboard connectdoesn't hand control back to the agent. The background sign-in it starts inherits the agent's output pipe, so the agent's command doesn't finish until the developer approves, or for up to 5 minutes. In Claude Code that means sitting on the command until its 2-minute timeout, without the link or the next step. Mac and Linux aren't affected.Windows passes every inheritable handle to a program it starts, not just the ones it's given, and the agent's stdin, stdout and stderr are inheritable. So before starting the sign-in,
connectmarks its own as not inheritable. It still uses them itself. Bumps the version to 1.6.1.Testing
connectwith "No reply within 90 s". The published 1.6.0 through npx hangs the same way.cargo test: the onboard unit and integration tests pass on macOS. The fix type-checks forx86_64-pc-windows-msvc.