Skip to content

Fail pty opens that ask for parity or 7 bits - #227

Closed
tallakt wants to merge 1 commit into
elixir-circuits:mainfrom
tallakt:pty-fail-unsupported-line-settings
Closed

tallakt wants to merge 1 commit into
elixir-circuits:mainfrom
tallakt:pty-fail-unsupported-line-settings

Conversation

@tallakt

@tallakt tallakt commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

Fixes #226. A pty can't do parity or 7 data bits, so opening one with them worked once and then failed with :einval. Fail the first open too, and document it.

@fhunleth

fhunleth commented Oct 7, 2026

Copy link
Copy Markdown
Member

Thanks! I hadn't realized it had been 2 days. This is on my todo list and I hope to make a pass soon.

@fhunleth

Copy link
Copy Markdown
Member

Hi @tallakt - I took a more generic approach to the fix in #232, but copied over your unit test from here. I think this should be good. Let me know if you have any concerns and if not, I'll merge the other one and make a release. Thanks again for the issue and taking the time to make the PR.

@fhunleth

Copy link
Copy Markdown
Member

I went ahead and merged #232 with your test from here. If I missed the mark, please let me know. Thanks again for reporting the issue and the PR.

@fhunleth fhunleth closed this Oct 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

open/3 returns {:error, :einval} on a pty when parity or data bits are set a second time

2 participants