Skip to content

fix(mint): stop leaking processes for failed requests - #593

Open
arrangabriel wants to merge 1 commit into
elixir-grpc:masterfrom
arrangabriel:fix/mint-process-leak
Open

arrangabriel wants to merge 1 commit into
elixir-grpc:masterfrom
arrangabriel:fix/mint-process-leak

Conversation

@arrangabriel

Copy link
Copy Markdown
Contributor

Stop the Mint response process when a request is refused

do_request/3 spawns a StreamResponseProcess and links it to the caller. When the connection process refuses the request, receive_data/2 routes to handle_errors_receive_data/2, which returns the error and leaves the process running.

Fixes #592.

Changes

  • handle_errors_receive_data/2 stops the response process. No request ref exists to cancel, unlike give_up_on_request/2 on the deadline path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

StreamResponseProcess leaks when the connection process refuses a request

1 participant