Repository navigation
MCP: connect falls back to mDNS discovery when no connection is configured - #23
Merged
Merged
Conversation
…gured connect() with no connection, no --connection and no BENCHPOD_CONNECTION used to fail with "no connection given". It now finds the one pod on the LAN over mDNS (as 'discover' does). When discovery finds none or several pods, or mDNS is unavailable, the error lists the pods it heard and what to pass instead: host[:port], 'usb', or 'embeddedci:<device>' from cloud_list_devices. The connect description, the status hint, the server instructions, the README and the CHANGELOG say so; unit tests mock discovery. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
connectwith noconnection, no--connectionand noBENCHPOD_CONNECTIONused to fail with "no connection given" (without mentioningdiscover). The embeddedci.com docs (embeddedci-server#71) now presentBENCHPOD_CONNECTIONandBENCHPOD_LA_VOLTAGEas optional for Claude/Codex app users, so the MCP server needs to find the pod itself.Session.connectfalls back toembeddedci.benchpod.connection._discover_one()(mDNS) when nothing is configured, and connects to thehost:portit finds.ConnectionConfigErrornaming the pods heard (name + address) and what to pass instead:host[:port],'usb','embeddedci:<device>'(cloud_list_deviceslists them), orBENCHPOD_CONNECTION/--connection.connectdescription,statusnot-connected hint and server instructions updated (tools_surface.json refreshed: only theconnectiondescription changed).No release cut.
🤖 Generated with Claude Code