Repository navigation
Digital-only board: skip analog e2e tests, add a digital tier - #37
Open
wardviaene wants to merge 5 commits into
Open
wardviaene wants to merge 5 commits into
wardviaene wants to merge 5 commits into
Conversation
Skips only on the digital-only board; firmware that does not announce the flag counts as analog. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
current_out and calibrate checked their capability first and told a digital board to update its firmware; they now raise UnsupportedFeatureError with feature="analog". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Analog tests carry benchpod_capability("analog") (ANALOG) or call
require_analog (cloud tier); mixed tests are split so the LA halves still
run. test_e2e_digital.py checks the board's own behavior: analog=false,
no analog caps, fast UnsupportedFeatureError refusals, dac_stop and LA
still work. BENCHPOD_EXPECT_BOARD=analog|digital fails the run on the
wrong board so a missed detection cannot pass green.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… docs The MCP and OpenHTF analog tests skip on the digital-only board; the MCP suite gains a check that the analog tools refuse with the digital-board hint. make e2e BOARD=analog|digital sets BENCHPOD_EXPECT_BOARD. The DAC limit lift skips a pod without a DAC. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The fake pod gains can_analog; a digital pod is not sent dac_limits. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Hardware run on the analog pod benchpod-baea06 (published fw 3.9.0, gw 48), with
No test skipped as "digital-only board" on the analog pod; only the digital tiers ( |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The digital-only BenchPod (no analog front end) reports
analog: false(firmware 3.6.0+). Until now every e2e suite would fail its analog tests there instead of skipping them.@pytest.mark.benchpod_capability("analog")followsBenchPod.can_analog: it skips only on the digital board (firmware without the flag counts as analog). The DAC-limit lift skips a pod without a DAC.current_out/calibrateon the digital board raiseUnsupportedFeatureError(feature="analog")naming the missing front end, instead of asking for newer firmware.ANALOGor callrequire_analog(cloud tier); mixed tests are split so the LA halves still run. Newtest_e2e_digital.py(runs only on a digital pod): status/caps, fast refusals,dac_stop+ LA still work. MCP and OpenHTF e2e skip their analog tests the same way; MCP checks the digital-board hint.BENCHPOD_EXPECT_BOARD=analog|digital(make e2e BOARD=…) fails the run on the other board, so an undetected analog section cannot skip half the suite and pass green.Verified: unit suites green; dry run of the digital tier against a fake digital pod; hardware run on the analog pod (see comment). The digital-pod run waits for the first digital BenchPod.
🤖 Generated with Claude Code