Repository navigation
Conversation
The invite activity was written in after(), behind the invitation email. When the email provider was slow (6-9s), the activity log didn't show the invite until well after the inviter saw "Invitation sent", which also made the team-invite-activity test flaky. Write the activity with the invitation and only defer the email. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced Nov 11, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
d07b423movedlogActivityfor invitations intoafter(), behindsendInvitationEmail. The email stand-in takes 6–9s about a quarter of the time, so the "invited a team member" entry often lands well after the inviter sees "Invitation sent successfully".People see that as a missing activity entry, and it makes
team-invite-activity.spec.tsflaky. In Endform it fails withReceived string: "You created a new team"onwebinar/mainand on unrelated PRs such as #13.Fix
Write the activity log entry along with the invitation, before responding. Only the email stays in
after(), so inviting still feels instant. The response now waits for one extra small insert, but never for the email.🤖 Generated with Claude Code