Repository navigation
fix: what the review of the drag routes and the trace turned up - #116
Merged
Merged
Conversation
A dropped node's edges: once the server's route reaches the ports it is drawn at once, inside the drag's 650ms settling window too; before, the live router kept drawing its own route until the window closed and the edge jumped onto the server's. The reveal fallback grows with the number of hidden edges (25ms each, 6s at most), since libavoid's time does. A node with no edges is walked once per drag, not once per pointer move. The selection trace reads a wire by where its two nodes stand rather than by their ports, so two nodes overlapping across the page (one under the other, or moved by hand) do not turn it round. A slid route must leave its port on a stub of 8px or more; a node moved up to its own bend had kept a 1px stub, a vertical exit to the eye. The unpadded node boxes come from the padded obstacles instead of a second walk of the model. libavoid's unkink works on the end it is given, source first and target last as libavoid lists them, instead of guessing the end by x-distance, which picked the wrong one on a U-shaped route. Claude-Session: https://claude.ai/code/session_01EToj6RJRMSSHQiqGNMU9wv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A medium-level review of #112, #114 and #115 after their merge. Six of its ten findings held up and are fixed here, each with a test where one could be written:
Left as they are, with the reasons: a pointer released outside the diagram sends no finished move, so its edges stay hidden up to the 5 s abandoned-drag timer (the price of keeping a node held still mid-drag hidden); the bootstrap reroute of a diagram with a saved layout and no saved routes goes through libavoid for up to 200 edges, a one-time cost at open that the perf line reports; the hidden-edge state stays a module map the view polls, as the other drag state is.
https://claude.ai/code/session_01EToj6RJRMSSHQiqGNMU9wv