Repository navigation
ci: report proto update failures at their source - #525
Merged
Merged
Conversation
Signed-off-by: rulex123 <erica.manno@gmail.com>
rulex123
force-pushed
the
fix/proto-update-errors
branch
from
October 30, 2026 09:14
943105a to
2b56a67
Compare
rulex123
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scheduled proto updater reports a misleading gzip error when Envoy dependency metadata returns HTTP 404.
curl -saccepts the error response, and the workflow'steepipeline hides the SHA-resolution script's failure, allowing the proto update script to continue.Use
curl -fsSLfor metadata and archive downloads so HTTP errors are reported and fail the scripts. Setshell: bashon the existing workflow step so GitHub Actions runs it with-e -o pipefail: a failure inupdate-sha.shpropagates throughteeand preventsupdate-api.shfrom running. Keep the original workflow commands.Adapting dependency resolution to Envoy's new Bazel metadata remains a separate follow-up.
Observed failure: https://github.com/envoyproxy/java-control-plane/actions/runs/40855490255/job/123385334334