Repository navigation
Conversation
Signed-off-by: rulex123 <erica.manno@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The daily proto update fails for Envoy v1.40.2 because Envoy removed
api/bazel/repository_locations.bzlduring its migration to Bazel modules.Read the root
MODULE.bazel.lockat the requested Envoy revision instead. Locate each of the six dependencies' registrysource.jsondescriptors and extract the source tag or commit from its archive URL. This handles both the public Bazel registry and Envoy's pinned custom registry, preserving the existingAPI_SHASformat and download process. Remove the old Starlark parsing and release-date comments.Use the root lockfile to match Envoy's resolved dependency graph, including CEL 0.25.1; the standalone API lockfile selects CEL 0.24.0. Envoy's dependency CI regenerates lockfiles and checks that they match the committed files.
Validation:
git diff --checkpassed.update-api.shusing the emitted revisions; it downloaded 727 proto files.Observed failure: https://github.com/envoyproxy/java-control-plane/actions/runs/40855490255/job/123385334334