Repository navigation
server: allow memcache health checks to pass - #1287
Open
ajaykr0905 wants to merge 1 commit into
Open
ajaykr0905 wants to merge 1 commit into
ajaykr0905 wants to merge 1 commit into
Conversation
Signed-off-by: Ajay Kumar <206070437+ajaykr0905@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1284.
Evidence
go test ./test/server -run '^TestMemcacheServerStartsHealthy$' -count=1failed withexpected: 200,actual: 500.After: the regression passed 10 consecutive runs and
go test -race ./test/server -count=1passed.make tests_unitmake check_formatgo vet ./...pre-commit run -aMerge Danger
Door: Two-way
The change is isolated to initial health state and can be reverted without data migration or configuration changes.
Blast Radius: Readiness
Only
BACKEND_TYPE=memcachestartup health changes; Redis continues to start unhealthy until its connection is confirmed, and config readiness remains independently enforced.Assisted-by: OpenAI Codex